Adding show/hide addresses to FlowDiagram #2325
Conversation
There was a problem hiding this comment.
This svg graph was incorrect, this is now fixed in this PR
There was a problem hiding this comment.
There is a different PR that pulls this out
| "bootstrap": "^5.3.5", | ||
| "bootstrap-icons": "^1.11.3", | ||
| "codemirror": "^6.0.1", | ||
| "hex-to-css-filter": "^6.0.0", |
There was a problem hiding this comment.
lib to help convert hex to filter
There was a problem hiding this comment.
This change was pulled out into its own PR
| <p>No heartbeat data received for this {{ tooltipTarget }}.</p> | ||
| <p>Have you installed and configured the <a target="_blank" href="https://docs.particular.net/monitoring/heartbeats/install-plugin">heartbeats plugin</a> for this {{ tooltipTarget }}?</p> | ||
| </template> | ||
| <span title="Last Heartbeat">No data available</span> |
There was a problem hiding this comment.
This was causing a double up of tooltips
| message.headers.findIndex(function (x) { | ||
| return x.key === NServiceBusHeaders.ExceptionInfoExceptionType; | ||
| }) > -1, | ||
| isError: message.status !== MessageStatus.Successful && message.status !== MessageStatus.ResolvedSuccessfully, |
There was a problem hiding this comment.
easier logic and also handles messages that have been resolved and should no longer be displayed as errors even though they do have a stacktrace
| level: 0, | ||
| width: 0, | ||
| XPos: 0, |
There was a problem hiding this comment.
This makes it easier as there is no need to ignore nulls
| } | ||
| function constructNodes(mappedMessages: MappedMessage[]): Node[] { | ||
| function constructNodes(mappedMessages: MappedMessage[]): Node<MappedMessage>[] { |
| } | ||
| const nodes = constructNodes(mappedMessages); | ||
| const edges = constructEdges(nodes.map((n) => n.data as MappedMessage)); |
There was a problem hiding this comment.
only passing the result of constructNodes to make up the edges, this prevents edges without parents
| <TextEllipses class="address" :text="`${data.sendingEndpoint.name}@${data.sendingEndpoint.host}`" /> | ||
| </div> | ||
| <div class="node" :class="{ error: data.isError, 'current-message': data.id === store.state.data.id }"> | ||
| <div class="node-text wordwrap"> |
johnsimons
force-pushed
the
john/flowdiag2
branch
2 times, most recently
from
421f155 to
56f47c7
Compare
| <strong> | ||
| <RouterLink v-if="data.isError" :to="{ path: routeLinks.messages.failedMessage.link(data.id) }">{{ data.nodeName }}</RouterLink> | ||
| <RouterLink v-else :to="{ path: routeLinks.messages.successMessage.link(data.messageId, data.id) }">{{ data.nodeName }}</RouterLink> | ||
| <RouterLink v-if="data.isError" :to="{ path: routeLinks.messages.failedMessage.link(data.id) }"><TextEllipses style="width: 204px" :text="data.nodeName" ellipses-style="LeftSide" /></RouterLink> |
There was a problem hiding this comment.
why fixed width style, and why in pixels?
There was a problem hiding this comment.
oh, i see, the pixel sizing is taken from the styles below...
still, why did the style have to move from a class to inline?
johnsimons
force-pushed
the
john/flowdiag2
branch
from
ee42783 to
1a82407
Compare
No description provided.