Skip to content

Conversation

PhilBastian
Copy link
Contributor

Implement tooltips as per ServiceInsight and integrate with new message view/message store

PhilBastian and others added 30 commits March 6, 2025 14:56
# Conflicts:
#	src/Frontend/src/components/messages/MessageView.vue
#	src/Frontend/src/stores/AuditStore.ts
# Conflicts:
#	src/Frontend/src/components/messages/SequenceDiagram/RoutesComponent.vue
# Conflicts:
#	src/Frontend/src/components/messages/SequenceDiagram/EndpointsComponent.vue
#	src/Frontend/src/components/messages/SequenceDiagram/HandlersComponent.vue
#	src/Frontend/src/components/messages/SequenceDiagram/RoutesComponent.vue
#	src/Frontend/src/resources/SequenceDiagram/RoutedMessage.ts
#	src/Frontend/src/stores/SequenceDiagramStore.ts
# Conflicts:
#	src/Frontend/src/components/messages/SequenceDiagram/EndpointsComponent.vue
 into sd_tooltips

# Conflicts:
#	src/Frontend/src/components/messages/SequenceDiagram/HandlerTooltip.vue
Copy link
Member

@johnsimons johnsimons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So are these tooltips added to the dom all the time or just on demand?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added only on mouseover after the specified delay

I don't understand what you mean by hard way? The linked page is what I used as the guide to my final solution

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant the advanced way

Comment on lines +7 to +10
function formatTime(milliseconds: number) {
const time = useFormatTime(milliseconds);
return `${time.value} ${time.unit}`;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be a component that is reused?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could use it in the list

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and probably other places

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

created an idea card

@PhilBastian PhilBastian merged commit 82a6402 into master Apr 10, 2025
5 checks passed
@PhilBastian PhilBastian deleted the sd_tooltips branch April 10, 2025 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants