Skip to content

cleanup TODO items #2338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

cleanup TODO items #2338

wants to merge 4 commits into from

Conversation

PhilBastian
Copy link
Contributor

@PhilBastian PhilBastian commented Apr 14, 2025 •
edited
Loading

  • move interfaces/classes that aren't directly read from ServiceControl APIs from resources to the component folder
  • extract util functions for DRY
  • add link to (currently ServiceInsight) help page for Sequence Diagram
  • fix Sequence Diagram startX offset that was broken by moving the endpoint render after all other elements

@PhilBastian PhilBastian requested a review from johnsimons April 14, 2025 07:54
@johnsimons
Copy link
Member

Could we separate these into individual PRs

@PhilBastian
Copy link
Contributor Author

will break this up as suggested by John

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soujay soujay soujay approved these changes

@johnsimons johnsimons Awaiting requested review from johnsimons

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PhilBastian @johnsimons @soujay