Part 2 of bringing over the all messages list #2346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsimons
commented
Apr 17, 2025
PhilBastian
reviewed
Apr 22, 2025
| }, 600); | ||
| watch(model, (newValue) => { | ||
| localInput.value = newValue; |
There was a problem hiding this comment.
i don't understand this change... seems to make localinput changes cause circular updates back to itself?
There was a problem hiding this comment.
will investigate separately and raise another PR if needed
PhilBastian
reviewed
Apr 23, 2025
- remove max-date limitation since it doesn't update without a full page refresh, and also server time may not be the same as client time
- fix applying query filters on loading of message list
PhilBastian
approved these changes
Apr 23, 2025
soujay
pushed a commit
that referenced
this pull request
Apr 24, 2025
Co-authored-by: Phil Bastian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this PR, we have added: