Skip to content

Add conditional messages when not supported #2359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 1, 2025
+40 −10
Merged

Add conditional messages when not supported #2359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da41891
Add conditional messages when not supported
johnsimons Apr 29, 2025
dbc0860
Fixed name of variable
johnsimons May 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/Frontend/src/components/audit/isAllMessagesSupported.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
import { computed } from "vue";
import { useIsSupported } from "@/composables/serviceSemVer";
import { environment } from "@/composables/serviceServiceControl";

export const minimumSCVersionForAllMessages = "6.6.0";
const isAllMessagesSupported = computed(() => useIsSupported(environment.sc_version, minimumSCVersionForAllMessages));

export default isAllMessagesSupported;
42 changes: 32 additions & 10 deletions src/Frontend/src/views/AuditView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,22 +2,37 @@
import { licenseStatus } from "../composables/serviceLicense";
import LicenseExpired from "../components/LicenseExpired.vue";
import AuditList from "@/components/audit/AuditList.vue";
import isAllMessagesSupported, { minimumSCVersionForAllMessages } from "@/components/audit/isAllMessagesSupported.ts";
import ConditionalRender from "@/components/ConditionalRender.vue";
</script>

<template>
<LicenseExpired />
<template v-if="!licenseStatus.isExpired">
<div class="container">
<div class="row title">
<div class="col-12">
<h1>All Messages</h1>
<ConditionalRender :supported="isAllMessagesSupported">
<template #unsupported>
<div class="not-supported">
<p>
The minimum version of ServiceControl required to enable this feature is
<span> {{ minimumSCVersionForAllMessages }} </span>.
</p>
<div>
<a class="btn btn-default btn-primary" href="https://particular.net/downloads" target="_blank">Update ServiceControl to latest version</a>
</div>
</div>
<div class="row">
<AuditList />
</template>
<LicenseExpired />
<template v-if="!licenseStatus.isExpired">
<div class="container">
<div class="row title">
<div class="col-12">
<h1>All Messages</h1>
</div>
</div>
<div class="row">
<AuditList />
</div>
</div>
</div>
</template>
</template>
</ConditionalRender>
</template>

<style scoped>
Expand All @@ -34,4 +49,11 @@ import AuditList from "@/components/audit/AuditList.vue";
flex: 0;
min-height: fit-content;
}

.not-supported {
display: flex;
align-items: center;
justify-content: center;
flex-direction: column;
}
</style>