Fix reset original body #2365
Merged
Fix reset original body #2365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsimons
force-pushed
the
john/editandreplay
branch
from
b5148cc to
15f8ebe
Compare
PhilBastian
reviewed
May 1, 2025
| const newValue = value.replaceAll(regExToPruneLineEndings, ""); | ||
| localMessage.value.isBodyChanged = newValue !== uneditedMessageBody.value.replaceAll(regExToPruneLineEndings, ""); | ||
| localMessage.value.isBodyEmpty = newValue === ""; | ||
| }, 1000); |
There was a problem hiding this comment.
these values affect the save? What happens during the second that you're waiting for the update to happen? Why is the debounce required?
There was a problem hiding this comment.
Becasue we don't want to fire this callback on every keystroke. The callback has a few things happening that can be expensive.
The worse it happens is that we won't see the "reset" button for 1 second.
There was a problem hiding this comment.
as mentioned in our call, this should be removed for the isBodyEmpty check, retained for the isBodyChanged
PhilBastian
reviewed
May 1, 2025
|
@PhilBastian I have updated the description |
johnsimons
force-pushed
the
john/editandreplay
branch
from
e4c8dfc to
12c61ca
Compare
PhilBastian
approved these changes
May 2, 2025
A few small other fixes
johnsimons
force-pushed
the
john/editandreplay
branch
from
12c61ca to
648cacf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The edit and retry dialog was suppose to show a "reset body" back to the original button.
But unfortunately the logic had a few bugs which cuased the button to not always be shown.
This PR fixes that issue as well as brings the button to the top of the dialog to be more inline with current design in other areas.