Skip to content

Saga update properties #2371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 1, 2025
Merged

Saga update properties #2371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
dd03a8c
animation vendor-specific styles for old browsers
cquirosj Apr 29, 2025
c822b25
selected border color
cquirosj Apr 29, 2025
d9350c6
Saga Update properties
cquirosj Apr 30, 2025
3a6268b
Remove grid in favor of diff viewer
cquirosj May 1, 2025
a026e30
Using codeEditor to display initial state
cquirosj May 1, 2025
49e8b54
remove backgrounds and borders
cquirosj May 1, 2025
079beef
inform if unable to parse the saga state changes
cquirosj May 1, 2025
c86e956
Adding the idea of maximizing the diff
cquirosj May 1, 2025
be847e2
closing maximized diff view using ESC
cquirosj May 1, 2025
af5edb9
exracting svgs from diff viewer
cquirosj May 1, 2025
0d4e09c
independent state v1
cquirosj May 1, 2025
6734be7
Split diff viewer to reuse functionality in popup
cquirosj May 1, 2025
59f1a93
stub CodeEditor for sagadaigram component tests
cquirosj May 1, 2025
3c64553
maximize button position fix
cquirosj May 1, 2025
9f573fa
update code editor background for saga first node
cquirosj May 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/Frontend/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions src/Frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
"bootstrap": "^5.3.5",
"bootstrap-icons": "^1.11.3",
"codemirror": "^6.0.1",
"diff": "^7.0.0",
"hex-to-css-filter": "^6.0.0",
"lodash.debounce": "^4.0.8",
"lossless-json": "^4.0.2",
Expand All @@ -52,6 +53,7 @@
"@testing-library/vue": "^8.1.0",
"@tsconfig/node18": "^18.2.4",
"@types/bootstrap": "^5.2.10",
"@types/diff": "^7.0.2",
"@types/lodash": "^4.17.16",
"@types/node": "^22.15.3",
"@vitejs/plugin-vue": "^5.2.3",
Expand Down
3 changes: 3 additions & 0 deletions src/Frontend/src/assets/diff-close.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions src/Frontend/src/assets/diff-maximize.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 2 additions & 1 deletion src/Frontend/src/components/CodeEditor.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ const props = withDefaults(
showGutter?: boolean;
showCopyToClipboard?: boolean;
ariaLabel?: string;
css?: string;
}>(),
{ readOnly: true, showGutter: true, showCopyToClipboard: true }
);
Expand Down Expand Up @@ -49,7 +50,7 @@ const extensions = computed(() => {
</script>

<template>
<div class="wrapper" :aria-label="ariaLabel">
<div class="wrapper" :aria-label="ariaLabel" :class="css">
<div v-if="props.showCopyToClipboard" class="toolbar">
<CopyToClipboard :value="code" />
</div>
Expand Down
Loading