Skip to content

remove duplicate spinner #2394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025
Merged

remove duplicate spinner #2394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 0 additions & 38 deletions src/Frontend/src/components/LoadingOverlay.vue
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions src/Frontend/src/components/messages2/MessageView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import TabsLayout from "@/components/TabsLayout.vue";
import { storeToRefs } from "pinia";
import MetadataLabel from "@/components/messages2/MetadataLabel.vue";
import { hexToCSSFilter } from "hex-to-css-filter";
import LoadingOverlay from "@/components/LoadingOverlay.vue";
import SagaDiagram from "./SagaDiagram.vue";

const route = useRoute();
Expand Down Expand Up @@ -105,7 +104,6 @@ onMounted(() => {
<no-data v-if="state.not_found" title="message failures" message="Could not find message. This could be because the message URL is invalid or the corresponding message was processed and is no longer tracked by ServiceControl."></no-data>
<no-data v-else-if="state.failed_to_load" title="message failures" message="An error occurred while trying to load the message. Please check the ServiceControl logs to learn what the issue is."></no-data>
<template v-else>
<LoadingOverlay v-if="state.loading ?? false" />
<div class="row">
<div class="col-sm-12 no-side-padding">
<RouterLink :to="backLink"><i class="fa fa-chevron-left"></i> Back</RouterLink>
Expand Down