Skip to content

Conversation

soujay
Copy link
Contributor

@soujay soujay commented May 10, 2025

fix the tippy text on the message node of flow diagram

@soujay soujay self-assigned this May 10, 2025
@soujay soujay changed the title fix the tippy text on the message node fix the tippy text on the message node of flow diagram May 10, 2025
Copy link
Member

@johnsimons johnsimons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tooltips on the addresses need to be removed.
We can't have 2 tooltips!

<Controls :show-interactive="false" position="top-left" class="controls" />
<template #node-message="{ id, data }: { id: string; data: NodeData }">
<TextEllipses class="address" :text="`${data.sendingEndpoint.name}@${data.sendingEndpoint.host}`" />
<TextEllipses class="address" :text="`${data.sendingEndpoint.name}@${data.sendingEndpoint.host}`" v-tippy="'Sending Endpoint'" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't do this, becasue the whole point of the TextEllipses component is it renders a shorter endpoint name with ellipses and then uses the tooltip to show the full name!

Otherwise it can hide the address expanded tooltip
@johnsimons johnsimons enabled auto-merge May 12, 2025 00:29
@johnsimons johnsimons merged commit 629c47d into master May 12, 2025
5 checks passed
@johnsimons johnsimons deleted the tippy-fix-flow-diagram branch May 12, 2025 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants