Revert test fix #2479
Closed
Revert test fix #2479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cquirosj
requested changes
Jun 20, 2025
There was a problem hiding this comment.
I think this can be closed, this PR is another attempt to fix the issue (pretty much the original solution you had, but with a small difference). This has been tested on a computer using en-AU to confirm. @jasontaylordev could you please test and confirm? 🙏 thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting the previous fix to these tests, as it still fails across different locale formats (e.g. en-AU).
The tests pass in GitHub Actions (which uses en-US), but they can fail in local development environments with different locale settings.
I’ve created a new bug to track and address this issue separately.