-
Notifications
You must be signed in to change notification settings - Fork 26
Add monitoring resources for maintainability #2495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not convinced this is an overall positive. Previously one could see the text that was displayed in the component and modify it directly (while in dev mode), seeing the output on the rendered page and correlating it to the JSX. Now there's a separate file that needs to be open instead, which breaks that mental flow
<section role="table" aria-label="endpoint-list"> | ||
<!--Table headings--> | ||
<div role="row" aria-label="column-headers" class="table-head-row"> | ||
<ColumnHeader :name="columnName.ENDPOINTNAME" label="Endpoint name" class="table-first-col" v-model="activeColumn" sortable default-ascending /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these were using a common resource already that matched that used in the store... the change makes this more likely to get out of sync
I understand your point of view. Previously, it was easier to see and modify the text inline. However, the improvement here is that all labels, tooltips, and units now come from a single, consistent source of truth. This makes updates easier and helps ensure consistency across the application. For example, a tooltip can now be updated in just one place instead of across multiple files. |
37cb4e6
to
b97fd13
Compare
This pull request introduces a refactor to centralize monitoring-related resource definitions and improve maintainability across multiple components. The changes replace hardcoded labels, tooltips, and units with reusable constants defined in a new
MonitoringResources
module. Additionally, a minor version update was made to themockServiceWorker.js
file.