Skip to content

Conversation

jasontaylordev
Copy link
Contributor

This pull request introduces a refactor to centralize monitoring-related resource definitions and improve maintainability across multiple components. The changes replace hardcoded labels, tooltips, and units with reusable constants defined in a new MonitoringResources module. Additionally, a minor version update was made to the mockServiceWorker.js file.

@jasontaylordev jasontaylordev self-assigned this Jul 1, 2025
Copy link
Contributor

@PhilBastian PhilBastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not convinced this is an overall positive. Previously one could see the text that was displayed in the component and modify it directly (while in dev mode), seeing the output on the rendered page and correlating it to the JSX. Now there's a separate file that needs to be open instead, which breaks that mental flow

<section role="table" aria-label="endpoint-list">
<!--Table headings-->
<div role="row" aria-label="column-headers" class="table-head-row">
<ColumnHeader :name="columnName.ENDPOINTNAME" label="Endpoint name" class="table-first-col" v-model="activeColumn" sortable default-ascending />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these were using a common resource already that matched that used in the store... the change makes this more likely to get out of sync

@jasontaylordev
Copy link
Contributor Author

I'm not convinced this is an overall positive. Previously one could see the text that was displayed in the component and modify it directly (while in dev mode), seeing the output on the rendered page and correlating it to the JSX. Now there's a separate file that needs to be open instead, which breaks that mental flow

I understand your point of view. Previously, it was easier to see and modify the text inline. However, the improvement here is that all labels, tooltips, and units now come from a single, consistent source of truth. This makes updates easier and helps ensure consistency across the application. For example, a tooltip can now be updated in just one place instead of across multiple files.

@jasontaylordev jasontaylordev merged commit 096f5f4 into master Jul 4, 2025
5 checks passed
@jasontaylordev jasontaylordev deleted the add-resources branch July 4, 2025 07:47
@PhilBastian PhilBastian added this to the 2.1.1 milestone Jul 7, 2025
@PhilBastian PhilBastian added the Type: Refactoring Type: Refactoring label Jul 7, 2025
@DavidBoike DavidBoike added this to the 2.1.1 milestone Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Refactoring Type: Refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants