Skip to content

All messages anchor links POC #2509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

All messages anchor links POC #2509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c31ab3
all messages anchor links poc
cquirosj Jul 10, 2025
2401cb5
add message type to the tab title
cquirosj Jul 11, 2025
0a56dee
using routerlink instead of anchor directly
cquirosj Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 26 additions & 16 deletions src/Frontend/src/components/audit/AuditListItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,28 +13,29 @@ const props = defineProps<{
message: Message;
}>();

function navigateToMessage(message: Message) {
const query = router.currentRoute.value.query;
function getMessageRoute(message: Message) {
const path = message.status === MessageStatus.Successful || message.status === MessageStatus.ResolvedSuccessfully ? routeLinks.messages.successMessage.link(message.message_id, message.id) : routeLinks.messages.failedMessage.link(message.id);

router.push({
path: message.status === MessageStatus.Successful || message.status === MessageStatus.ResolvedSuccessfully ? routeLinks.messages.successMessage.link(message.message_id, message.id) : routeLinks.messages.failedMessage.link(message.id),
query: { ...query, ...{ back: route.path } },
});
const query = router.currentRoute.value.query;
return {
path,
query: { ...query, back: route.path },
};
}
</script>

<template>
<div class="item" @click="navigateToMessage(props.message)">
<div class="status">
<RouterLink :to="getMessageRoute(props.message)" class="item">
<span class="status">
<MessageStatusIcon :message="props.message" />
</div>
<div class="message-id">{{ props.message.message_id }}</div>
<div class="message-type">{{ props.message.message_type }}</div>
<div class="time-sent"><span class="label-name">Time Sent:</span>{{ new Date(props.message.time_sent).toLocaleString() }}</div>
<div class="critical-time"><span class="label-name">Critical Time:</span>{{ formatDotNetTimespan(props.message.critical_time) }}</div>
<div class="processing-time"><span class="label-name">Processing Time:</span>{{ formatDotNetTimespan(props.message.processing_time) }}</div>
<div class="delivery-time"><span class="label-name">Delivery Time:</span>{{ formatDotNetTimespan(props.message.delivery_time) }}</div>
</div>
</span>
<span class="message-id">{{ props.message.message_id }}</span>
<span class="message-type">{{ props.message.message_type }}</span>
<span class="time-sent"><span class="label-name">Time Sent:</span>{{ new Date(props.message.time_sent).toLocaleString() }}</span>
<span class="critical-time"><span class="label-name">Critical Time:</span>{{ formatDotNetTimespan(props.message.critical_time) }}</span>
<span class="processing-time"><span class="label-name">Processing Time:</span>{{ formatDotNetTimespan(props.message.processing_time) }}</span>
<span class="delivery-time"><span class="label-name">Delivery Time:</span>{{ formatDotNetTimespan(props.message.delivery_time) }}</span>
</RouterLink>
</template>

<style scoped>
Expand All @@ -49,6 +50,8 @@ function navigateToMessage(message: Message) {
grid-template-areas:
"status message-type message-type message-type time-sent"
"status message-id processing-time critical-time delivery-time";
text-decoration: none;
color: inherit;
}
.item:not(:first-child) {
border-top-color: #eee;
Expand All @@ -64,25 +67,32 @@ function navigateToMessage(message: Message) {
}
.status {
grid-area: status;
display: block;
}
.message-id {
grid-area: message-id;
display: block;
}
.time-sent {
grid-area: time-sent;
display: block;
}
.message-type {
grid-area: message-type;
font-weight: bold;
overflow-wrap: break-word;
display: block;
}
.processing-time {
grid-area: processing-time;
display: block;
}
.critical-time {
grid-area: critical-time;
display: block;
}
.delivery-time {
grid-area: delivery-time;
display: block;
}
</style>
12 changes: 11 additions & 1 deletion src/Frontend/src/components/messages/MessageView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<script setup lang="ts">
import { computed, onMounted, ref, watch } from "vue";
import { computed, onMounted, ref, watch, watchEffect } from "vue";
import { RouteLocationAsPathGeneric, RouterLink, useRoute } from "vue-router";
import NoData from "../NoData.vue";
import TimeSince from "../TimeSince.vue";
Expand Down Expand Up @@ -98,6 +98,16 @@ onMounted(() => {
backLink.value = { path: back.toString(), query: otherArgs };
}
});

// Update document title to include message status and type for easier tab identification
watchEffect(() => {
if (state.value.data.message_type) {
const statusEmoji = isError.value ? "❌" : "✅";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't add emojis to document.title, I think it would look funny given that by default it displays the site icon, so we would endup with double icons

document.title = `${statusEmoji} ${state.value.data.message_type} - ServicePulse`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

messagetype can get quite long, so not sure this is a good title

} else {
document.title = "ServicePulse";
}
});
</script>

<template>
Expand Down