move monitoring relation functionality to monitoring store #2685
Conversation
| isMonitoringDisabled, | ||
| isMonitoringEnabled, |
There was a problem hiding this comment.
¯_(ツ)_/¯. I guess it makes it more readable in the usage sites if it's a positive or negative based usage
| fetchTypedFromMonitoring, | ||
| deleteFromMonitoring, | ||
| optionsFromMonitoring, |
There was a problem hiding this comment.
I don't understand what you're referring to
There was a problem hiding this comment.
Example, instead of await monitoringStore.fetchTypedFromMonitoring<EndpointDetails>(${monitored-endpoints}/${endpointName}?history=${historyPeriod}); we would call monitoringStore.getHistory(endpointName, historyPeriod)
Or instead of monitoringStore.fetchTypedFromMonitoring<number>("monitored-endpoints/disconnected"), we would call monitoringStore.disconnected()
There was a problem hiding this comment.
if we applied the same logic to the servicecontrolstore, we'd have ~100 different functions exposed from the store.
It's an idea worth exploring, but not as part of this refactor IMO
There was a problem hiding this comment.
not really a store, just utilities
There was a problem hiding this comment.
yeah but couldn't find a good place for it so I just put it coexistent with the stores that use it
| export function getParams() { | ||
| const params: Param[] = []; | ||
|
|
||
| if (!window.location.search) return params; | ||
|
|
||
| const searchParams = window.location.search.split("&"); | ||
|
|
||
| searchParams.forEach((p) => { | ||
| p = p.startsWith("?") ? p.substring(1, p.length) : p; | ||
| const singleParam = p.split("="); | ||
| params.push({ name: singleParam[0], value: singleParam[1] }); | ||
| }); | ||
| return params; | ||
| } |
There was a problem hiding this comment.
we probbly should use https://developer.mozilla.org/en-US/docs/Web/API/URLSearchParams#parsing_window.location
There was a problem hiding this comment.
can change in another PR.
part of #1905