Open
Conversation
|
This Pull Request may conflict if the Pull Requests below are merged first. #25 |
|
This Pull Request may conflict if the Pull Requests below are merged first. #27 |
PastaPastaPasta
force-pushed
the
a-test-conflicts
branch
from
ce13465 to
6155d7c
Compare
|
This pull request has conflicts, please rebase. |
PastaPastaPasta
changed the base branch from
potential-conflicts
to
use-pasta-action
|
This Pull Request may conflict if the Pull Requests below are merged first. #25 |
1 similar comment
|
This Pull Request may conflict if the Pull Requests below are merged first. #25 |
PastaPastaPasta
force-pushed
the
a-test-conflicts
branch
from
6155d7c to
061ad72
Compare
|
This Pull Request may conflict if the Pull Requests below are merged first. #25 |
1 similar comment
|
This Pull Request may conflict if the Pull Requests below are merged first. #25 |
|
This Pull Request may conflict if the Pull Requests below are merged first. #25 |
PastaPastaPasta
force-pushed
the
a-test-conflicts
branch
from
061ad72 to
7452ed9
Compare
|
This Pull Request may conflict if the Pull Requests below are merged first. #25 |
3 similar comments
|
This Pull Request may conflict if the Pull Requests below are merged first. #25 |
|
This Pull Request may conflict if the Pull Requests below are merged first. #25 |
|
This Pull Request may conflict if the Pull Requests below are merged first. #25 |
PastaPastaPasta
force-pushed
the
a-test-conflicts
branch
from
7452ed9 to
e6b1daf
Compare
|
This Pull Request may conflict if the Pull Requests below are merged first. #25 |
1 similar comment
|
This Pull Request may conflict if the Pull Requests below are merged first. #25 |
|
Hello world ! 👋 |
PastaPastaPasta
force-pushed
the
a-test-conflicts
branch
from
c1c8dfd to
bb9302f
Compare
PastaPastaPasta
pushed a commit
that referenced
this pull request
Sep 7, 2023
fa2e614 test: Fix off-by-one in mockscheduler test RPC (MarcoFalke) Pull request description: Fixes: ``` fuzz: scheduler.cpp:83: void CScheduler::MockForward(std::chrono::seconds): Assertion `delta_seconds.count() > 0 && delta_seconds < std::chrono::hours{1}' failed. ==1059066== ERROR: libFuzzer: deadly signal #0 0x558f75449c10 in __sanitizer_print_stack_trace (/root/fuzz_dir/scratch/fuzz_gen/code/src/test/fuzz/fuzz+0x5fec10) #1 0x558f753f32b8 in fuzzer::PrintStackTrace() fuzzer.o #2 0x558f753d68d3 in fuzzer::Fuzzer::CrashCallback() fuzzer.o #3 0x7f4a3cbbb3bf (/lib/x86_64-linux-gnu/libpthread.so.0+0x153bf) #4 0x7f4a3c7ff18a in raise (/lib/x86_64-linux-gnu/libc.so.6+0x4618a) #5 0x7f4a3c7de858 in abort (/lib/x86_64-linux-gnu/libc.so.6+0x25858) #6 0x7f4a3c7de728 (/lib/x86_64-linux-gnu/libc.so.6+0x25728) #7 0x7f4a3c7eff35 in __assert_fail (/lib/x86_64-linux-gnu/libc.so.6+0x36f35) #8 0x558f7588a913 in CScheduler::MockForward(std::chrono::duration<long, std::ratio<1l, 1l> >) scheduler.cpp:83:5 #9 0x558f75b0e5b1 in mockscheduler()::$_7::operator()(RPCHelpMan const&, JSONRPCRequest const&) const rpc/misc.cpp:435:30 #10 0x558f75b0e5b1 in std::_Function_handler<UniValue (RPCHelpMan const&, JSONRPCRequest const&), mockscheduler()::$_7>::_M_invoke(std::_Any_data const&, RPCHelpMan const&, JSONRPCRequest const&) /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/std_function.h:285:9 #11 0x558f7587a141 in std::function<UniValue (RPCHelpMan const&, JSONRPCRequest const&)>::operator()(RPCHelpMan const&, JSONRPCRequest const&) const /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/std_function.h:688:14 #12 0x558f7587a141 in RPCHelpMan::HandleRequest(JSONRPCRequest const&) const rpc/util.cpp:565:26 #13 0x558f756c0086 in CRPCCommand::CRPCCommand(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, RPCHelpMan (*)())::'lambda'(JSONRPCRequest const&, UniValue&, bool)::operator()(JSONRPCRequest const&, UniValue&, bool) const ./rpc/server.h:110:91 #14 0x558f756c0086 in std::_Function_handler<bool (JSONRPCRequest const&, UniValue&, bool), CRPCCommand::CRPCCommand(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, RPCHelpMan (*)())::'lambda'(JSONRPCRequest const&, UniValue&, bool)>::_M_invoke(std::_Any_data const&, JSONRPCRequest const&, UniValue&, bool&&) /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/std_function.h:285:9 #15 0x558f756b8592 in std::function<bool (JSONRPCRequest const&, UniValue&, bool)>::operator()(JSONRPCRequest const&, UniValue&, bool) const /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/std_function.h:688:14 #16 0x558f756b8592 in ExecuteCommand(CRPCCommand const&, JSONRPCRequest const&, UniValue&, bool) rpc/server.cpp:480:20 #17 0x558f756b8592 in ExecuteCommands(std::vector<CRPCCommand const*, std::allocator<CRPCCommand const*> > const&, JSONRPCRequest const&, UniValue&) rpc/server.cpp:444:13 #18 0x558f756b8017 in CRPCTable::execute(JSONRPCRequest const&) const rpc/server.cpp:464:13 #19 0x558f7552457a in (anonymous namespace)::RPCFuzzTestingSetup::CallRPC(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&) test/fuzz/rpc.cpp:50:25 #20 0x558f7552457a in rpc_fuzz_target(Span<unsigned char const>) test/fuzz/rpc.cpp:354:28 #21 0x558f7544cf0f in std::_Function_handler<void (Span<unsigned char const>), void (*)(Span<unsigned char const>)>::_M_invoke(std::_Any_data const&, Span<unsigned char const>&&) /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/std_function.h:300:2 #22 0x558f75c05197 in std::function<void (Span<unsigned char const>)>::operator()(Span<unsigned char const>) const /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/std_function.h:688:14 #23 0x558f75c05197 in LLVMFuzzerTestOneInput test/fuzz/fuzz.cpp:74:5 #24 0x558f753d8073 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) fuzzer.o #25 0x558f753c1f72 in fuzzer::RunOneTest(fuzzer::Fuzzer*, char const*, unsigned long) fuzzer.o #26 0x558f753c7d6a in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) fuzzer.o #27 0x558f753f3a92 in main (/root/fuzz_dir/scratch/fuzz_gen/code/src/test/fuzz/fuzz+0x5a8a92) #28 0x7f4a3c7e00b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x270b2) #29 0x558f7539cc9d in _start (/root/fuzz_dir/scratch/fuzz_gen/code/src/test/fuzz/fuzz+0x551c9d) ACKs for top commit: practicalswift: cr ACK fa2e614 Tree-SHA512: cfa120265261f0ad019b46c426b915c1c007806b37aecb27016ce780a0ddea5e6fc9b09065fd40684b11183dcd3bf543558d7a655e604695021653540266baf7
PastaPastaPasta
pushed a commit
that referenced
this pull request
Jul 29, 2025
a44caf65fe Merge bitcoin-core/univalue-subtree#28: Import fixes for sanitizer reported issues 135254331e Import fixes for sanitizer reported issues d5fb86940e refactor: use c++11 range based for loop in checkObject ff9c379304 refactor: Use nullptr (c++11) instead of NULL 08a99754d5 build: use ax_cxx_compile_stdcxx.m4 to check for C++11 support 66d3713ce7 Merge bitcoin-core/univalue-subtree#29: ci: travis -> cirrus 808d487292 ci: travis -> cirrus c390ac375f Merge bitcoin-core/univalue-subtree#19: Split sources for easier buildsystem integration 4a5b0a1c65 build: Move source entries out to sources.mk 6c7d94b33c build: cleanup wonky gen usage a222637c6d Merge #23: Merge changes from jgarzik/univalue@1ae6a23 98fadc0909 Merge #24: Push bool into array correctly 5f03f1f39a Push bool into array correctly f77d0f718d Merge commit '1ae6a231a0169938eb3972c1d48dd17cba5947e1' into HEAD 98261b1e7b Merge #22: Clamp JSON object depth to PHP limit 54c4015415 Clamp JSON object depth to PHP limit 5a58a46671 Merge #21: Remove hand-coded UniValue destructor. b4cdfc4f47 Remove hand-coded UniValue destructor. 1ae6a231a0 Merge pull request dashpay#57 from MarcoFalke/test_fix 92bdd11f0b univalue_write: remove unneeded sstream.h include ffb621c130 Merge pull request dashpay#56 from drodil/remove_sstream_header f33acf9fe8 Merge commit '7890db9~' into HEAD 7fba60b5ad Merge #17: [docs] Update readme 4577454e7e Merge #13: Fix typo 66e0adec4d Remove unnecessary sstream header from univalue.h ac7e73cda8 [docs] Update readme 7890db99d6 Merge #11: Remove deprecated std pair wrappers 88967f6586 Version 1.0.4 40e34852ac Merge #14: Cleaned up namespace imports to reduce symbol collisions 1dc113dbef Merge pull request dashpay#50 from luke-jr/pushKV_bool 72392fb227 [tests] test pushKV for boolean values c23132bcf4 Pushing boolean value to univalue correctly 4a4964729b Fix typo 85052a4819 Remove deprecated std::pair wrappers 81faab26a1 Merge pull request dashpay#48 from fwolfst/47-UPDATE_MIT_LINK_TO_HTTPS b17634ef24 Update URLs to MIT license. 51d3ab34ba Merge #10: Add pushKV(key, boolean) function (replaces #5) 129bad96d5 [tests] test pushKV for boolean values b3c44c947f Pushing boolean value to univalue correctly 07947ff2da Merge #9: [tests] Fix BOOST_CHECK_THROW macro ec849d9a28 [tests] Fix BOOST_CHECK_THROW macro 88ab64f6b5 Merge pull request dashpay#46 from jasonbcox/master 35ed96da31 Merge pull request dashpay#44 from MarcoFalke/Mf1709-univalue-cherrypick-explicit 420c226290 Merge pull request dashpay#45 from MarcoFalke/Mf1710-univalue-revert-test d208f986dd Cleaned up namespace imports to reduce symbol collisions 31bc9f5a49 Merge #8: Remove unused Homebrew workaround fa042093d1 Remove HomeBrew workaround a523e08ae4 Merge #7: Declare single-argument (non-converting) constructors "explicit" a9e53b38ba Merge #4: Pull upstream fe805ea74f Declare single-argument (non-converting) constructors "explicit" 8a2d6f1e36 Merge pull request #41 from jgarzik/get-obj-map ba341a20d7 Add getObjMap() helper method. Also, constify checkObject(). ceb1194137 Handle .pushKV() and .checkObject() edge cases. 107db98299 Add ::push_back(double) method for feature parity. d415300316 Move one-line implementation of UniValue::read() to header. 52e85b35b8 Move exception-throwing get_* methods into separate implementation module. dac5296759 README.md: update code quotes 3e31dcffbe README.md: close code quote d09b8429da Update README.md f1b86edb4c Convert README to markdown style. 1dfe464eff Import UniValue class unit tests from bitcoin project. 0d3e74dd1e operator[] takes size_t index parameter (versus unsigned int) 640158fa26 Private findKey() method becomes size_t clean, and returns bool on failure. 7099135857 Merge pull request #36 from ryanofsky/pr/end-str a31231b519 Version 1.0.3 4fd5444d18 Reject unterminated strings 81eba332b7 Merge pull request #26 from isle2983/pushBackHelpers 36405413e8 Merge PR #32 from branch 'nul-not-special' of git://github.com/ryanofsky/univalue into merge 89bb07322a Merge pull request #31 from ryanofsky/raw-literals 511008c36d Merge pull request #30 from ryanofsky/test-driver 77974f3a9f Merge pull request #34 from paveljanik/20161116_Wshadow_codepoint a38fcd3556 Do not shadow member variable codepoint. fd32d1ab85 Don't require nul-terminated string inputs 0bb1439d0d Support parsing raw literals in UniValue 28876d0455 Merge pull request #29 from btcdrak/exportspace 839ccd71f3 Add test driver for JSONTestSuite 26ef3fff15 Remove trailing whitespace from JSON export 16a1f7f6e9 Merge #3: Pull upstream 3f03bfd62b Merge pull request #27 from laanwj/2016_09_const_refs 5668ca397b Return const references from getKeys, getValues, get_str cedda1473d Merge pull request #28 from MarcoFalke/patch-1 9f0b997592 [travis] Work around osx libtool issue daf1285af6 Merge pull request #2 from jgarzik/master cfa0384d64 Convenience wrappers for push_back-ing integer types d9e62d3e19 Merge pull request #24 from MarcoFalke/Mf1608-cleanup faf260f2f8 Rem unused vars and prefer prefix operator for non-primitive type 09a2693ff1 Merge pull request #22 from laanwj/2016_04_unicode c74a04c259 Merge pull request #23 from paveljanik/20160527_Wshadow f32df99e96 Merge branch '2016_04_unicode' into bitcoin 280b191cb1 Merge remote-tracking branch 'jgarzik/master' into bitcoin fceb4f8e84 Do not shadow variables c9a716c2b9 Handle UTF-8 bed8dd9258 Version 1.0.2. 5e7985a3f8 Merge pull request #14 from laanwj/2015_11_escape_plan git-subtree-dir: src/univalue git-subtree-split: a44caf65fe55b9dd8ddb08f04c0f70409efd53b3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.