Skip to content
This repository was archived by the owner on Oct 21, 2025. It is now read-only.

Conversation

@Peechey
Copy link
Contributor

@Peechey Peechey commented Jan 18, 2025

Fixes #339

Description of the problem being solved:

Attribute nodes do not count as Small Passives, so we need to ignore them when adding stats from Against the Darkness

Link to a build that showcases this PR:

eNrtPWlz28aSn8NfgWJVtnbLtIT78Mp5RYo6mEi2IkqW4y8uiBySiECAxiGJfvX--3bP4BiAAAhSearkbfxBJme6e7p7erp7Th7943npCo8kCB3fe9-VDsSuQLyJP3W8-fvu7c3pW7P7j586R1d2tPg4G8SOizXyT50fjugXwSWPxH3ftdSuMHHtMPxgL8n77rXtzUnQFexwQrzpcV4xJPaUrElXiOxgTqJPacPiVwkILOzAnkQkuECi_TjyL_0pIM1sNwSUpe14Y3_yQKKzwI9XwG1XeHTIEwMaXV59vL7pAmc_HF259poE48iOhBD-vO_2QUJ7Tob2Ev4Clu3GgCKZpioemLKkyaIsqd3DRuRBHITRfhTGK0KmGZJ8YJlmHehVQE5mMzKJnEdyHDjR8cL2JnmDxoFch7k79GXsRs7KdbCnMt5UpQ7lfIO-JIp1wDd-ZLvDq3EGq-mypR8ohmqIstqM5UcZVi39OydaDFxQ685tIOZo7jkR2Qv1yndC39tbMh6xVrjj2HVhmLWCvSYhCR7tyCkyVU_bX9473h566wfE_jhjxnltT504vCRRQELedupwL23PPvbDvF81uQn0igTgN6IChrgFYUwmPrgaHkXSNBBKb9FSNX5tkxfOjLSH3EmaBGFXbvaT42TcFm5nwvsxdA3OtR3k2I_dlpBR7t6UWrMbkufckEWtfrR9awk58jhDFOUGgjykZdQz-OjjIN8uMHU1J-dXXPOWqRzoqiyJmi7V-verxTp0JrZ7aT87y3gJ7v7GfiB5g4qka_U2OF9EHvisOmRJlszalk-dgOyFeOy70_0QF7Yf1mJKWn2AvoQs5Nz2pv3JJIZsZZ1jqYraNERzo4H-aMgUJu8QeuRNcsp6E91bL6AhgM8wGlpAlGsYkpjU3LukNU7eTDK022QBrLE58ZIWOW2JB0oT1gUhk8UZ6PrajnImzQNLbwwyOaSlNeoYgXkdN4aXChU30C9i7KAtRKzWlqofNDZXra16l7hyIP3j4qTRDFkhv9YWoyy_ciCZqiEpiqEZll7rF088EszX44VDXM6ulTbgqfaO7VULTGoNPHorqyi2V9VlrVB37Lc7O5i2C6K78vRoh3xs0WTLbFYYQ-B1JZv1JkogUweUKSlNIHSjfh7k_46zIHdHvH6w9OOgzRAAKRhwqw5PgyObAF6TaTxpF42z2dzAhblrSY7tWMCn6-6E2o8ie_Iw9Kdz0haFNrITRpG_cbxawXhHi2hLAEM-TF0cLoMztO3AH8GeC-O6KTNoTT8HLtOXrK0ZT-tWShjlptTGXKXcShvocgvbe_MS_MUSvDVdsLj0c2cjHWj1LvQUpqs7TycpUvV8OKE3fnBcVwjx75UdAEpXCGG4Tgj9VFSp0A8C_2k3Dq78J9DPAheiwhYOgIOGxDGPZ7UCBsT7vm5NvwDeqoETbwoZKIy21m2UMaqaGcSzWShM_OW9HV2AEaGy76GMfT52bYju655wDumjOxX8mXCziL0pCXpCqTN6wp3jTYUhtgcOGbLlkCQEWUs3zhLiQhgO7cgWpsn05hPQt71Ipqt7IbGDyQKRTm3XvQe3Rrs-K8VvJUQJEZH-0SFdoMRPo-XKDyKBPON_aErrdE2RAtISoBNGjkfXUcCHum5XGC_8p_70Efm_8X03zBYi7dWKeNMCjZuAEMFOPeIEmaAy4hdhaYcRhGE2ykJkmlsXHU2pqJ4PDEBg00RL6mmmYhk91ZQkvaeIPV1UTbEni6Yi9UxI1nqSrEtST1dM0-ypiqT0FM0SpZ6iqiZ8xnlPT5VMw-gppiGbUCsrak-xTKOnSbqo93TJkiWgIski0FdUQAXiVk83TKsH6RnQllQd-IA0TQc4WVPgsyEaSFzTAFoHLhRNN6SebIoqEBctUevpsqqrwJEqK0jGkHuyAi3LpqlowJFo6SCUYUClZYrAl6nq8FnVoGnZtCwZmjItsadZBjKm6QAPmQjQFTWgrpmSgU1DgSKLFoABi7Iqg1iqbmrYDsD1ZMkAtYCGgF1ZkiSgqhigERBWAe2AvoCegQyZoAoggsIpBoiiiaoG8kumrCG0AVRAZ1Cu6xqoyLBUHdpQZIQBWOBN0bFcNUEBkg5tAGFQAMijA4-SBAoArWs9WTNEsQd8AZOqCVL3VBmoATMydJssqRbCiKBZWQW96KqkghZ0UzLxrwodbiEEaAfUAqoHq1BFSUP2VOxwA9Qo66oCokoKlCuGAuwBLQPgoSOBDZidglFYFnYBTG_FnqoaQEfVLVC4KqtgaSoYgYyqhL-aIiIzhglNgQXpEvQG6ASydrQ10LiuaiqzMlAkqBD1q1rQp2AwwLKMnYhCQJnaM1B_qgp6BPE1yBNhDOOikB2s-8WR4Dkw8CIYTKWdgbRepMPqh6Pb6wv64YdFFK3Cd4eHT09PBys7Wvgz8gxJ4wE4sMMVIMGAfEtDyFuketiHf4N5fzB71IbaADqh3yfGyeD68_PX6eXtlfYwGH75fSifhYqs-Nrd5_Fo6Qy1q5_dx_PFhbSQF58Xypl_e345639aj-aPysQzZl8i5em36PP9b89qPPu1_-2LNfql_0Amv3ycOxf66c3d8d3V998vJrf99V3sjhylfxu8ff5yGriK9rT--VR0iWJMzu6__Pzp_OyzcevNJWltDoZ3s-jq-eJM__Xz-HitPl-sNTGwpAt3uIq_jb8_fR8tx_fnj0Pj0_fx98_eyVA7ffhycvf2MdS9X_y7L7dfpwvlyfXf-t-nZqReDczoZjQy5osPlvigfDW-iP3wUjtTP8_t8w_nwc9P4tq5_8XwV_fH_jiYOKcX7lycn44M_enp8rf1zdfB298fjM-nlx9Gg9vBN13_9P1uPVB-Dxa2tf6136cdc5j2zBHbqglZNyXfqJvDfqRW1hWciCypA0zSrE1AOlRzQFmqA6T2xgGKdYB0uHBNG7WA6E45QL0WEMc-B5hMnUAZvA6OMB0LHHDzCRVI1APnPo5IWgEx6PkDiwOJm6SuKHHu1B2yUZ44d-oD2AijjhNY8KKEAHMWbMAz98niAvOXzKUn_pK6HIwlmFUFCT5zTcxDM3fPvAENSpl8BZFAXIh2NPRiOMQPH_yI1WFh-uWIJnYhJHNBdEaW4WANyd4pTodLuxNJPEXoMYlYRsDjvO9GQUwwBZjZsYvlv8a262B4p34kL79gu5SeHyyz9U0gBgEepy6M5s16hYL3Ly6S0J20KzjTNJwnhXQnsp8zd2y7k5Cy53gTNwaj8JIUNuXQte-x_Ys-7q7ists0rSmRylr64QhYomkbsDCCBOs5EYrhn7n-ve3KGX0mHwyjQr2U1j-y5AitM8vSkoyZOsfNCpY7doVvqUZhQAlzZuCXJLKnkLQdjsDiw0Psj0PKPWq6RN6zl0lGtJGrlzQx8WMvyuUHXXPCC3PIWyMyZTlUHbMO01PuI5A3Tp2NutuuulOax7H5dWI3nP6SEh5oQ4lbdJjZ4iWkpI7t3hDIXHkdJuVCUlGnwcM_TubRhAzAsdWKm9TvLWmCzwsJRQIrewX57oi98r0Tl0570-WdWmkrofeW_SpwwB31wSct6QpprgJWI-RVr6CJczKLagXHyp3k5MREXF449v01bNcLV05Ap3T19pvD7G_DOY2CHfPFzeIeMf-5PcbQELAZZWhxEmS2hxiEbqllWdwholzjgtFmPIHiHU2nHEso4apIQitewZKSkzIkX5UOay2qAnZvyxpP7AiiCSQqhRFUKH4F8Y99D_dwwJbTCFwr_Sbo3sJvkuJ1wNcKafUr6AJDLwmj2I9DGoVrNVEG3FsP104Itp6Q41XAKoSs5jUswfVDckwXB-tNIIfZv-9zGoVOx2IhLf-L-lSYH7YIxri8-nE2wr2UTMFc6a6aTVxqgS4fktPVXFrxCobUn07JNHPkW9KuKuC9TSujM_JmcViK2XloyWtfY1gt2CrzeOE3TC0KUC9xq9nmZcGdZqWvkppNAmKHZMqfKmxI0iqgXzC5mnvOzKkKKlnVa0YUXESZ0A2ZWgXkIHtLnZPgBeZL_6ru1GrvTpO9qgqXmtS80K1m9Ktca1b5Wu4Vt7XbeNYc7gVOBQ_ObPpTLH9dV3rm2hOnec6Xg-wtb06Cl5YvfQVRT-1gSyqWQewfLX1vXp5-5GWvICR3spTuotbKWgZ8eYKQEKrOD7LKV5l_udMr4pFoy2JGCe5Fo5mjszGgC3V_1bDRRu_Qxx89mm5xykbdcTV7howCbU6_UCz4npBUvNi4Wkg5sF03s2tOzkL5nlKWaOdyYoXA1bzCKBq7eISnzRLOBuTeI2lIJsQlm8OoWP4aCfdyRaK4XuSkft813gS9sPyZFr2CdOxM7TWJiNfoIEtw-0pbIsNLzaoEru4_eOUXD3il57syVeeF-6368kRzvRbOkr2CRQ1caLDWjmjt3k6BYhecISt4lfU7en6vYe2O1r9g3Y7iF9fskqLWAyH5OCYRPUzAjgvgRzoUKMTIW8URbeR9d-mEk694RBEvAtMzDPTy8snp6cnxzejTSXLckEehYn_14uU9tTL6f8bK0ZjQhRAhjO9D9vF995NDnigjQ5DfcUPk33XtVUiyg4D0oEDCuYuLB_XUKNS5k10nrqaVA9RTOnkmQQTy3tnBJHBILV9Z_RamWIN4bQCPZ9ZRwyu69YTY5jdmMuxaQ42m6KXoeip4Q7lWHKxswIXYY7u1LSe1WzQR4XkQsGBn5kzwKEJzl-PpEQbVoJfsylhtfyfH5-tp0DvPdQRYZT0yu7tch53UNmiV3pqu1SqrrUeHnMeulZ1V1iNnN2V87xyvLlVTyaAaKH3wPWrkeHjEcXF7vbZnT1ySgdQT_BgtSJAc7q2jdAk-KgVpHDjsRFgtHQ6iQVf0tmGNhrCuHpXdoauRAesaBk1yqaxutDvNQ7Z44aumP3iYelLsmlStH2xCZRcnatWf3MJo6MHk-lFN77HaBiWk97Bq5E-qG8YYdd_9R9-Zsns4NaOtBNbkb-g89KVk6OWil5Mp3zZ6OcVT1w4favs7qa1Hv4XpISQ3FVRYktOKCI7Jl1HAofkyCngjZLk39nU5i8lxr5vzl-zuSiVyWtvkNpIrLXtTYBdv9kan94L2xqaxY0hmBCRoDB4ZTMPgiGJvGKdrCi8iRdmq9iK5dDvRYmG0UtKdKbLRndzZb3IADGQLIcgDzhsyzXaUsht058R28ZEY330ZwY23CV5CDC8Cxyvbm6bkPlbl93k_tNSeH4VAk16zGuJ945fq0CPLdQWher6ODtMZIb2AhXO05HbYOApwPeS77y9_e99VRfXA0GTdFDXL0lhxciRcUpNz4JC7Dx3oxYBaX9oqQn5-330ri7J8IEqqpWqimFx0PqIz4OSUOn7ODqnX04tDwt5DYSdJKUa6KEPp8afNr-nE-Z1w3b8-6dzBwF4IY5zrkaBz8ryCeZ8whPk5m-8KA_-pQwlQwd4JpthJTsO_E2Sxk9xEeCeMhXHnOvbIO2EUQAfgx43vlMQ1-fZOMMwOzJZcZ-IgrtL5J0gDU5ToX_8MAPBfqvgjrkmxzXkhvSMtsH7KgfvTaShIkhD5gqQK9IZqCgNsC2y-GAozJyCC7Qn2dOqgSdATsAHIRTcdGAIwobzVrA5P5B3QfiupHZwU0vbBzAU2k3onaAei-GMnbQK0JrAOAKQD0Iska00iUM5lETmX9epaRcFazRI4LjtvZOtHLM5YYuXQS14cdhRoM8Ar5NBiltELoPAYNECnG50zPO8OxAVMDijbdHigaKCOIIhXEZnSdZNLf0qfWxMC_Pu-Kx5o3cSKkpWVWgh5K4SyFcLcCmFthZDE7SDbpZG2i5M9fkNXr4qDTq4YdJe46jgAKtPOJ9-FHhF-jWGwB8WRJnEDRhf5ASN1ZJM3L2rOAl35YMYjGdS0tLJpYWliswkgligmd8l2ugGoFNrKty-SBt_ICExZxeMIuAHDw9BVto4s8zQqRpQw84OsRZxqC6aA6Sdno78ApT-HcapbIbStEPpWCKPeqJQKoxq42IfCeEHcKHflp_BNOLZXnWSSB6YELrxgZ3KNR0_898Cfrsv-W9eK5ljy32_A8sAmlizZoL6m80YysSxhQ7i2MeR0JEXnDaNU-0axeDpoD1BGbXZInkFKYLrzRlWpT-SOb9PpNFoVGKfGHCb161zF31aEDGxa0bW9imKIl7igkdoQvtI5w0tQAQQjO8pNSbIUrZ0t7ZQdFK1Lbs4O2OJHLzMdcKpCslvGVnQ6ipiHRdyCRRO58iMgukaHNST39G0CwP3Nj8FiVKPKUEWjyVBlUd-0eFWhtofPjBRtUmowWElRsRJnXcLNIiCQ9bn__5ze9sygyqC1okHffhj9envSwWfVsKPvnHDqL6mB9OncoHMaB5hkC5AEr0LOQ4qdggWBDSovdpmavLvLlJWSq5OoPxx5EXHB2-MUoKMUBgMNoCww08gJVHP0POJLImd9G6kBxQSQQjt_JQussg29wtmNH2LIVmBS50xJ6uwubPQTAx9mobyjswoGYLxOzFQKni59RSfNuyS1wufo6mbElKxqP6QkkwmcYBRdUL1_-jtuYtWmKZ36RPhgO26nvyQRJN2RcI2BoT6hV4vWkCp9I1FJ7Ez4b1YD_OJJ8iD8n3cCRJ0fAZHNI8sRyZI2DEGReHNi7NPLGXTBYebHMB9J0qvC0H8j69W80Txd25hM_jGJ-n9ERDIrTOXcjhJbufFX9vcKQxF5Q5FKhpIsAVSOztxYcExv2AoNADQNB5vZNjWUqXdRkgWIzWnhG1OsSPJlyhxOArPrzByDgKXUJEWqXumM_k582piZVWFmJ_Yc5t83fjCB-OTaMLtexi6J2loal3b3XdefgNGGMF-fL4S-C3ESww_NU-kGbEe1mrJjVeFAFW27F5ILgY8eXk2DnlhpPn-HJbrctWkFeNd_TqZT6I0LmqXADO9pga_CDIgbdej-HM6K2DpsrW1oemn9qbCeQ_1_-iyoMAsgy2Z7e-AklE0nURGapEKHU-QSVbyRi2tNHMfgTIxKp4GvAKfoEMKSA7E0QrEXov62F7b2WbCXy_7Z6LhzToJ7fApkYdOJMlM3DM9ogcvMsRc5s9gtGIpq5ckwbzOKUbSZW-zapwXxhLUfC_fQEUsinAb-d-J1LmCI47I0W0QPO8e-F8ZL8DgQZKBxSTKFZNcT5-lxSDrHcRBAeHHXwsIOeYB0jXu0XMYe-hZ0FwEh30knMSZBZcZBeUGuOmphiTMltK83luQqxY5XgR-jPxTOwFyh5YJqxzE0CVNSXrG6Xq1YTWxSLGZfgo2OlQh-INx6zreYsMwsUbOUqLmsZfjbqOS8PtOkIpZVqag_pku6oPg5Zoh2glbm0Uu4qtGiUqXFQXx_jz9iIdy6kbPETIq2zzxGqsu1-2iXVGkVJmx1C-tiKhhalJiYCRN00zQlqjRDa1ZaXk-nc4CRuTR7hb-SghfZ0G8BAk2oQ0E8kHOi-dbSv3FyLKlVui68hZDpm67KF_T9iQRT4L84QxZ3Vbgmq4z2H6ZvvZCU9JfovVLtg6VmyhZfWdlapbLBqkEptvdf9soP_zes9BL9e8iONlSt_ZvcxIEq1jpkWd3ikHOAUsaXniXpaPrOTvdl8U6vXB7so4-CBBP1O7SDB4-EYQdPMby98KF46NhLtIfS-h_7qZp3wgVy3blwlg4OkshHRRfse7ykO2LszchkOwzEFhgBmCmFPnuFTCjMzgsZ0wc_wjPurajQOblKHU0ysYPeOHmGUVzYSf5jEqBKNVctj5yAG_FXa-EkDOmSwsmS3l8ualUpak4q5ZjF9cqOXLfw2VFrl0SfnGiBRxrCjlTwDYmmaDWe2hHsxCjo8MAVY258ONus9FXzx8ouqFp2-OSgdxsSF2Zh8bK6B0q-uXZtudQ33H5v2jnii9S74RmWmbdBzD_VLnBlB1RNyI9tUKC7DnH2Qnf7K7ug5D4kqXLjnD_3wW2dp-pX6ztObe44yfwPHhdy1QwZZGTvc4M2nLDdwCiaP68l5lzEqoCXuWT6WGVyAQCjZ6q8Yt_cY99mBs9m1SffYme1gm_JeZHiMCvuGQrOjAb6hf1IkqQiglkXhH-EQ5KQCtGA_WfvNakhoIwXdKO6os8Mrdhncpuo8DLr5672UrULkvEj_vxker6leAiNG3w0Kzv1gwdcLjN2tYI_bffhM7d1RxOL79-6fkQfOr66v72-wCOW7ELdmQu5epi_gZytiNQhsEYEiXs2eRsKm8rwGMo2FLaSmmNY2xBYCOMfc9baofBstZSEf_9abakvDkfehoLrhlwT2Rk7tgk6mgJw-T1uhvgzeSKuwD3RnRJuIJC8080T4J7uLhPYYhTC-Al_tiRlXdyGhxszvGrMJk6T17p5TrkHvFtySveN08s-abNqU7PJ--R8s9yT5bspSK5VUJW87Bnzgrz5y-YtG6Ya5mzcaDcqeBPfaq_nBCItZ7FKo1TsFfeCVPnD7q170Y84p6XzvjG9fUx3O-jlY9-bOfPkuDf7khz4pkhZScFf8peOIQCFUX8SyR_oM-SfYLpJ1umCwY0T2XjuPb29XDxRUJVZp8JVNnEcxGRLC5LWamegqhmMEjQ40lWISxvm4NMuREDfJbaXHHWvQFtmvzd8YzvuE7sEn969FpvkUZjKbugalge8HQfrVVSrrnxHM8ne8mSrqhWCUozCgR9yFOm3rbLTm_uthM9EoV1TL0m6cVbew09pXrn2hKAkMEfk2E9-YjpVpyGKWxAKvyqVom1DKr3BmCNqsr6tPe7nqTOsehz2EiLdwN64oF_fRvaQ2S6c4RblTli5HeMPQuMSJWX0GJctx8SdcQxrLTgud4LSuhd2xqSdXpZVlrahFX_8bhfdZhdaM8OU1RaGUm6oSbDxxKcXflqbSujMHffjjF7cAzR6-7CthaUhP4W30stA9SjJLwb6rkszcn6MtjDMui4-OswCDrsIRb_91Dk6xEPAH2f0VhaYiPxT5_8APeWB9A==

Before screenshot:

image

After screenshot:

image

@Peechey Peechey added the bug: behaviour Behavioral differences label Jan 18, 2025
@LocalIdentity LocalIdentity changed the title Fix attribute nodes getting Against the Darkness mods Fix Against the Darkness applying to Attribute nodes Jan 18, 2025
@LocalIdentity LocalIdentity merged commit b761e3f into PathOfBuildingCommunity:dev Jan 18, 2025
1 of 2 checks passed
@Peechey Peechey deleted the fix/ATD-affecting-attribute-nodes branch January 19, 2025 05:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug: behaviour Behavioral differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Against The Darkness - small passive skills increases are not calculated correctly

2 participants