Skip to content
This repository was archived by the owner on Oct 21, 2025. It is now read-only.

Fix some increased critical damage modifiers incorrectly applying as base critical damage modifiers #31

Merged
merged 1 commit into from
Jan 18, 2025
Merged

Fix some increased critical damage modifiers incorrectly applying as base critical damage modifiers #31

merged 1 commit into from
Jan 18, 2025

Conversation

@PJacek
Copy link
Contributor

@PJacek PJacek commented Jan 18, 2025

Fixes PathOfBuildingCommunity/PathOfBuilding-PoE2#211
Fixes PathOfBuildingCommunity/PathOfBuilding-PoE2#267

This affects Supercritical, Snipe and Sunder

Before screenshot:

image

After screenshot:

image

@PJacek PJacek added the bug: calculation Numerical differences label Jan 18, 2025
@LocalIdentity LocalIdentity merged commit b191ea1 into PathOfBuildingCommunity:dev Jan 18, 2025
1 of 2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@LocalIdentity LocalIdentity LocalIdentity approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug: calculation Numerical differences

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sunder Crit Damage Bonus Incorrect(?) Calculation Supercritical support gem acting as 100% more crit multi.

2 participants

@PJacek @LocalIdentity