Skip to content

Buildup parsing/implemention #1378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 27 commits into
base: dev
Choose a base branch
from
Open

Buildup parsing/implemention #1378

wants to merge 27 commits into from

Conversation

@ImmotephSimon
Copy link
Contributor

@ImmotephSimon ImmotephSimon commented Sep 14, 2025 •
edited by LocalIdentity
Loading

Description of the problem being solved:

First iteration of build-up support, including Freeze, HeavyStun, Electrocute and Pin

Fixes #1499

Steps taken to verify a working solution:

  • Add parsing
  • Add buildup table in data
  • Add poiseThreshold to data from ggpk
  • Update boss settings to use poiseThreshold
  • Add buildup modifiers to output
  • Visualize output in calcs (specifically Electrocute, should probably be discarded and reworked) to confirm reasonable numbers.

Link to a build that showcases this PR:

Maxroll

Before screenshot:

Red text.

After screenshot:

image

@ImmotephSimon
Add parsing/support for buildup mechanics
03ccf97 
Add poise from data
Add poise to ConfigOptions
@ImmotephSimon
Add pin buildup
1e539f4 
Add data table
Clean up code
ImmotephSimon and others added 25 commits September 15, 2025 23:59
@ImmotephSimon
Add breakdown for buildup
0bdcf89 
Add breakdown support in CalcOffense
@ImmotephSimon
Add all damage types to stun in data
22cd1f5
Fix Poise Threshold + Misc.lua
76c3c7d
@ImmotephSimon
Redo removed export
08fcf51
@ImmotephSimon
Merge branch 'buildup-parsing' of https://github.com/ImmotephSimon/Pa…
bb61e42 
…thOfBuilding-PoE2 into buildup-parsing
Fix misc and add poise number
857072a
Update breakdown
619ec06
Fix parsing for proj pin + remove pin damage type
8286c2d
@ImmotephSimon
Add Bone Cage pin mods
21807de
@ImmotephSimon
Undo duplicated electrocute-change
9ea674e 
Simplify base_all_damage_can_pin
Tree / Gear mods for builup
4e1f5e9
Fix breakdown
2c6bd44
Add support for a lot of skills with buildups
23a709a
Fix Lightning damage innately affection electrocution
106af0c
Innate Melee / Phys damage Stun bonuses
6841fa3
Adds support for buildup from:
c5d9487 
Rime
Chaotic Freeze
Leap Slam
Shield Charge
Freezing Mark
Merge branch 'dev' into buildup-parsing
29b2908
Fix Pin support not disabling Stun
548be0a
Fix Melee Damage buildup not working
6331dc1
Fix Enemy Poise multiplier
494d69e 
The base value in MonsterVarieties is 100 so we need to take away 100 when applying it as a more multiplier
Merge branch 'dev' into buildup-parsing
5c3f4e8
Merge branch 'dev' into buildup-parsing
10f8239
Add stat name to config mods
f7a3351
Use enemy damage taken instead of pre hit mitigation
4276961
Fix Quality on Overwhelming Presence not affecting threshold mods
fe4a6a2 
The stat was not being applied as a AuraDebuff so wasn't being properly scaled by the Aura effect quality mod
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Quality on Overwhelming Presence does nothing

1 participant

@ImmotephSimon