Guess main socket group based on dps + Full import button #1401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nightblade
reviewed
Sep 17, 2025
Musholic
force-pushed
the
guess_socket_dps
branch
from
a8c4a6a to
9ea3115
Compare
Musholic
force-pushed
the
guess_socket_dps
branch
from
9ea3115 to
4856c3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
This PR allows to have a one-button full import while allowing to better guess which socket group is the main one based on DPS calculations of all groups. It also includes the main skill in Full DPS.
Note that if we cannot import with only one button, it causes an issue where the variable
mainSkillEmpty = #self.build.skillsTab.socketGroupList == 0is false because there is a skill coming from the tree ("Called shots" in my case).This is also useful for the automatic test I'm preparing to have more relevant tests (having a skill correctly included for the full dps stats) (Musholic#11).
Steps taken to verify a working solution:
Before screenshot:
After screenshot: