Remove CMD flash on updating runtime files #1518
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we update runtime files, SpawnProcess flashes a cmd windows quickly on the users screen before disappearing. This PR is reliant on the SG PR to work
LocalIdentity
added
enhancement
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we update runtime files, SpawnProcess flashes a cmd windows quickly on the users screen before disappearing. This PR is reliant on PathOfBuildingCommunity/PathOfBuilding-SimpleGraphic#89 to work
Sometimes the CMD window showing up is helpful though as it can show a error thats occurred when trying to update.