Skip to content

[pob1-port] Fix: EmmyLua annotations, add/improve two stub functions #1597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LocalIdentity merged 2 commits into from
Dec 15, 2025
Merged

[pob1-port] Fix: EmmyLua annotations, add/improve two stub functions #1597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4153e67
Apply changes from https://github.com/PathOfBuildingCommunity/PathOfB…
Nightblade Dec 15, 2025
7372056
Fix merge conflict
Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/HeadlessWrapper.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ function imageHandleClass:ImageSize()
end

-- Rendering
function RenderInit() end
function RenderInit(flag, ...) end
function GetScreenSize()
return 1920, 1080
end
Expand Down Expand Up @@ -157,6 +157,7 @@ function OpenURL(url) end
function SetProfiling(isEnabled) end
function Restart() end
function Exit() end
function TakeScreenshot() end

---@return string? provider
---@return string? version
Expand Down
2 changes: 1 addition & 1 deletion src/Launch.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ end
---Download the given page in the background, and calls the provided callback function when done:
---@param url string
---@param callback fun(response:table, errMsg:string) @ response = { header, body }
---@param params table @ params = { header, body }
---@param params? table @ params = { header, body }
function launch:DownloadPage(url, callback, params)
params = params or {}
local script = [[
Expand Down
12 changes: 6 additions & 6 deletions src/Modules/BuildSiteTools.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ buildSites.websiteList = {
}

--- Uploads a PoB build code to a website
--- @param websiteInfo Table Contains the postUrl, any postParams, and a prefix to add to the response
--- @param buildCode String The build code that will be uploaded
--- @param websiteInfo table Contains the postUrl, any postParams, and a prefix to add to the response
--- @param buildCode string The build code that will be uploaded
function buildSites.UploadBuild(buildCode, websiteInfo)
local response
if websiteInfo then
Expand Down Expand Up @@ -72,9 +72,9 @@ function buildSites.UploadBuild(buildCode, websiteInfo)
end

--- Downloads a PoB build code from a website
--- @param link String A link to the site that contains the link to the raw build code
--- @param websiteInfo Table Contains the downloadUrl
--- @param callback Function The function to call when the download is complete
--- @param link string A link to the site that contains the link to the raw build code
--- @param websiteInfo table? Contains the downloadUrl
--- @param callback function The function to call when the download is complete
function buildSites.DownloadBuild(link, websiteInfo, callback)
local siteCodeURL
-- Only called on program start via protocol handler
Expand Down Expand Up @@ -103,7 +103,7 @@ function buildSites.DownloadBuild(link, websiteInfo, callback)
end

-- Parses and converts URI's to import links. Currently only supports protocol handler URI's, extend as needed.
-- @param uri String Example: pob2://pobbin/<id> or pob2://poeninja/<id>
--- @param uri string Example: pob2://pobbin/<id> or pob2://poeninja/<id>
function buildSites.ParseImportLinkFromURI(uri)
local importLink = nil

Expand Down
Loading