-
Notifications
You must be signed in to change notification settings - Fork 260
Add Traveler's Wisdom Support #1665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
Please fix spelling before this is merged. ❤️ |
|
was about to request this as a update, glad someone is working on it. |
|
@Nightblade / @justjuangui Hey guys - HNY :) I fixed up spelling mistakes on a branch here if that makes life easier: #1682 |
HNY too, thx for the help, but like Local said we was on vacation, and i just arrive, but just to keep in mind, even if i fix, it doenst mean that it will merge soon, because depends on maintainers :D, this week i will fix this PR in my branch. |
Wires77
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the spelling for you. Do we know what happens in game when you deallocate this node? Right now those nodes turn into "+5 to any attribute", which isn't ideal.
Looks like this also broke the hotkeys specified in the popup menu

Finally, we should parse the contents of the ascendancy node so people know it's implemented
…proved flexibility and maintainability
6de5e21 to
8b34ad8
Compare
Description
This PR:
Format with backward compatibility
Evidence