Skip to content

Conversation

@n1tr0xs
Copy link
Contributor

@n1tr0xs n1tr0xs commented Nov 8, 2025

Description of the problem being solved:

Kinetic Fusillade DPS calculation currently is wrong. This caused by skill complexity.

Currently, i've implemented two types of skill:

  1. Attack once and wait for fire.
  2. Attack until 12 projectiles collected and wait for fire.

Steps to fix Kinetic Fusillade

  • - Support for attack speed
  • - Support for projectile count
  • - Support for duration

Steps taken to verify a working solution:

  • Play with projectile count
  • Play with attack speed
  • Play with skill duration

Link to a build that showcases this PR:

eNqtXG1z4jgS_jz5FS6qruquihC_g1NktwghL3NhkoVksntfUootgmeEzVhyErK1__1akjHmxcYGZqoSsPvpbrVa3S25nfbvHxOivOGI-mFwVtMaak3BgRt6fvB6Vnt8uDxu1X7_7ah9j9j4bnQe-4Tf-e3oS1t8VqYoYGMcBn0_CKOr0DurfQsDXFPcMYqQy3B0i98w6cQs7IcePquxKIa7hF88qxkOEBJE6Tc0gXtPPnPHNeXNx--S-KZ_fzd4qCkvKPB8Nmc9QX4wDN2fmF1FYTwFpWsKQ9ErZt_nwzCeYRiIujjwugv-Ep5qjH5kNYYhfWnfEzTD0ZAhplD4cVbrgGXQK75AE_gJqiESAyPdcRpm09BapqNZmlk7KQSfxxFlu3EYTjH2UpDZaGp5lNc-WyZu5lHeR7g3GmGX-W-4G_msO0aBu9BMcxr5-mygNxqmaelFgH5MmD8lPo4Ww2-oZsFIVlVq5dE-hAyRi_vhgrHq2A1D03XHNFW7GBayFKbmUYJLjs8J2LW6kJvXwGc4i7OaDbXpaM1my2wVCVxH6pplNAxHM5u6bplF2PvQp2Gwu0mq6tuNCYGAkIXlGnOAKY7eEPOXFcyl74aTFz9YsX0pS3QijO5G0s0HyPNj2scswnThUo1cl-2jAHVDunAOu4jyHkcQZdgSQN0CGGI3hMCUheithl5GzmZ0rsBbf4TLU1YaSwKoqs1u4-gNy9JVZrybQgMI5uUoh2FMSlKyRYDMD8EX-KME1U3AMuFTz1-Rv7KUumnli30L-cLdPgwRSXrX94sMYRsN2zCalm7rju3k5qXxjPouIn304U_iCaSBB_QTLwRampHvWK9jFkAYysMaZm46vPQjvAOsGxJvF9gYhTQXp2v5IcAPrqEK6rhuDHXVbDG5duFyK2M9qBvcU058E7jlFvFjEIlQnik3CmdnhAewtng19EJwWchCSLJEF2NW1WJZrzhIBM7KDegWY3d8BTYeIIbLxfHMMNRCy3LirGWNwji_0bRqOUQFO3HgZjtpaqNZhKpoql6Ao9fZcOxj4lWjnmvWRdMSsZNbOosu5cvL4ip5TRZa0SRPKPLKZZiqOr0hmg3RmlVsLkleylJ9DEUwADy8Upur-duM8AffZJBqsE40CeOo5IRL4lIDmGcXuQ8bYC92y6WzdK90TmDPWXYYKQr0JKQStMMYcn9ehN5raaMJIZUQy_oN4-kUggj3hrIMeNqEet7PFDbH-dXDgvoOXLnUiuYJtryABXVpAWnRUF7KCqT8WHjWXxVjlyEvLSKd0D4EiwlkAXEa0A8XkSa3triELVz1LZZAbd0vJryHP31CEuB_YUvHfFe5jClchNCQt1NVKCxuF67DJ46_RxHA7wKsILFE8kWcY8oUuYtWchVM2W9QKCMvN6CE7zA1Y37uREuEnww1lH-LYiDXvBEOPmel-S-RlxLQCzyoJGGtl5axitgk5sGfQKag9AIxBAbmh3SXPmE4ugBn5ljOX_GSzcR3FPkoYJo4wlu5qIuLFKPIHd8CWLhB-u0SEfICPpDMT_tEnEbyT90wGPmvCpLnW-LLEDPOTCiYXlF8T54c-oxgvr8ZoZgwQfSlfRNMYz7sSJyCCm-gygiCmGIryPN8riciyjTNcfRIU_-l-IEbYUSxl3ioQvkiPLJUuMetonADyrQTiBNJN6YsnMAqpdJ-wuouHkM0w5ESxJMXHMG60E1tjsABnsyWk1kR1FjCpfHrHnYdBahUGvVffXI3Et4LnsDdpABmLQnLnBUWYJpQo2ZR8hCzANBy7GUxPFhuN0Q6pOEYvHLIZ6d4LMtqZdJdKSFuCI66XcrazHI52wezotxqJivSMJ2jSXoqy48NcYQ9oW43jCF3YDIq4mJrTstZUiEp24rmzVzWmT8BKPRcdc2bKhsmU0MUuuASKKkQQ0IGKCgWtzZ96UxsV3UNy5UtsaDVde8vMe2qZi6HgvleoXTs4OptCRvGmiungPZJGnhFuJbf-MeHCOPvPn5XPsNw8icvv-xWw2k2dcjQ_NJfXPtWs-HousqT9jh85znpwoeCB5Kei-n8oZLMDkMW8VTBobfyKZOsRdo3DE9oEV6mDE6WJAwlplgeCj5hNA0DcXmECE2eFnHSJI0Iowwgc7HZqTLoDHpH32BInOAINkLTMXZnyhMKvKNuhEYMe6cKlwn38Mj_OFX-jrirnWr_3IYQ1jueh72FO2jq83MR5SJmAGUR4Yp3aurRMB4JYv4ErODLHzEiYmQ6QERSp6fK-TH8PxI2HuBfp4rdOrqZQEBxfX5XO_ob8gU9dRGF7P_sCYn15Je8-E-iotqw_vm3YR-b6n-yKVTsTBSp6hHoTxVN1xQWKrqmKnzMy_c0cU9rOQq33NI9CTNMU0ktML_PXRnSr1jp84pAaAV1SsOaO_sShb6VwthKYa5TtE-4t6R-lalQir3wS3tIQqAFzP3L4-CWOz__cuOJUksuyGtMJsCw8zKjFOoWOYeKPdetBAcpW9FXeVgVeGzWwjyAFnp1HtoqD6MCjysCuyy6jxabbVHFmuehN1Nk3l1lo1ViEzJ6cAb6vgzsfRkYhzFlFe88x4Qd3ie0A_j23ta0DrBIq5jykiD6c5eh68rwHU33ckeYxV1MvkmutndM0Q5g-BJLQVsdTgWxHdhKYFbZz3cY2G5L-lCTWXkRVaAf8JrkEHOtVRVqHCC8VJmYK14A75awN02KufcKM3YNMocKTnZl62mHyW3WAabe2tv--3OwD2OOg_mkXjnRGQdY-fbedty31jlEKDEPwEPbcxwHKzvMwzimXdmfDubK-2_v9t4JVC8b9_XjffH2ofxH23UaD-N3xt6Tb1StRvTKQexQtjYqu5m1p5tYh1LdOtRqN7JHUfKolh_QIg8PxdnqE-bnZ1Q-cRPnqeKJGyIulQdXS4_NepeXve7Dzfde-sjBp-7zSzwa8e7-RJSErD944o_cnuXlhHKIRceGOBUTD3uHmMClmuKGhKApxd78WEyh8QuV1Gc1frYsyC8wQz6hG7hdp48WtvASfK6XH0QscXoCK0U-f5hazKj3gSMGRkrp11mJ9vQS6khdeIcQf_a6yVbytYBiVrLppIsoEz1M61z485dtTDjNpqHcTKaIbDVuQpUz2Q-zKebn9rSUURhQ0yl2_ZHvStTGWZ83u2yxzbzncp2HeDVgG14SrYNlq_42dEK1waqiv2GrVSXVBv_CLpptQ0uidXDa8baNQUoYBmDvDZx6BHd8whtWts7stzAQzg7rJoWsM-xDkJHNMFsZ3vHnnnPadU6wJiL_JWbbl3OGcoOtRBvuFjNxmg1jEX2mxVBBs8GuS32XW6JRlnZjUNvKQtCsQ-c9T8VgSbVxCpJuwC3mzxzzLBth3hC5ZfzZZ6HLi0QE185b6HtlIsUq-d4MRePgAfTirYH7s1ntFdzAUVRGW9dLQlUKnjzbzaAfmc-fRu7HhK-4_Tjwhbcfhwc_cFkcbYwag9VyZB0-2FyDpP1cheA51a74tBlsZw6yZW1nuOhJyon_F3gknuyXSgAp8X68hiwOLubtXRVYrY9MaFUURCrzktmyYKAyECRvo5SJcZJ0f0aQy683F40VOKW9r9cYEf4KZEj2Y7j6gk55ZhtWKXbDeIoCb87tLr9Ur2K9kFFgKtoeL_hrAnQvLXui82nBp30y39W1v4VQ13DW_Or8Sxuq9TBiCv7gv3in7GyupoCLKwqaTnGw0H84Dt873hv36geYI5re8DCF3RBKsjmRsyc6g5KmHN7tn7Zw8i8K421Di9e99Sbv_-FNEiiadRYvfvO9b-CTpZfBk_2wO__M25ZgQwrqWLpj102tZda1ptV06rrmGGbdcCxdq5um0zLqlq3aQKK2TBWucErbcEyzbrZazVZdUw2tbqi6btUNw9BUuGmazbrV1G2zrpuGrdctTTPtuqVzSt1ptoDebjZBoA3363BTV-uWqcJnWzVarbrVslUTUJYOirS0pl3XAQZ8TM7ZMG1bA5RlwU-9Zekg3dFBQacJ6gO9CRz0Fv-pmoCyDdVu8qFYFozTbHJKG7CGwUeuObZh1fVmiw8dSHT-rj3v1JklRfJZLWk5eRzcig9fxoxN6enJyfv7e2OK2Dgc4Q-f4IYbTk6mYF-Yu2Oxlz_mE3bSgX_nr_3O7WD43rsc935pT_FkcvXGHNoNTJ9O7oObt9jsnRt_DV7HTUNzjt__nEXXM0qfvcun--kP5_P26-fD1fHbT-vu8-vg6-Pr08vs-n9DddT_MTA_6ddP8sfDndt_DB0Sv03sm9776K7b680-X-68TxfkiwGczEfQTvqZkhMUvjgjH5whOQjhviaWA3dG_mEoe4ETt5THELJZTHSWQXEE6-EKT_h-FezVub2VdzqEJV1UcHPh-VRS0_PZxf1wvjA92YsM15MOtiCMJumLkSugS161r7wrvWCQyOQOL9dOonG2bU1eVAh64bLk31foLMYnAoEYIQ74-3tp_IDqhcQevgmSDvz59RV8KudLGxRKmFyR8AURPQ1F8377VWGSTlui42s26dnPtOyvKJf8hQkdFvqvhQ3mn2-8Rce38iqPyPqYIQ8xJA-2TriBT8QA4NO6uMwbAhrvghc965s14ydaMoBteNPA5f226csZ3OM448T5kskSDigd77ej9snqn-L4P-Hred0=

@n1tr0xs
Copy link
Contributor Author

n1tr0xs commented Nov 8, 2025

I need some help to implement this to final result.
I haven't found how to get this values:

  1. kinetic_fusillade_maximum_floating_projectiles from skill constants
  2. attackTime from activeSkill or output

For now, i suppressed kinetic_fusillade_maximum_floating_projectiles to 12 via MAX_PROJECTILES, attackTime to 1.
I would be very grateful if someone could tell me how to get these values.

@Wires77
Copy link
Member

Wires77 commented Nov 8, 2025

Very related to #9183

@n1tr0xs
Copy link
Contributor Author

n1tr0xs commented Nov 8, 2025

Oh. I did check on issues, but didn't check PRs.
Sorry 😅

So i'm definitely closing this one, i guess.

@JustinStitt
Copy link
Contributor

JustinStitt commented Nov 9, 2025

BTW @n1tr0xs, the file you modified in your patch has this line at the top:

-- This file is automatically generated, do not edit!

Just pointing this out to help in the future, try modifying src/Export/Skills/act_{int,str,dex}.txt for active skill gems. (I am new to PoB development so I am just sharing info I just learned this week to try and help out) 😄

edit: more context is available in CONTRIBUTING.md:241

@n1tr0xs n1tr0xs closed this Nov 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants