Skip to content

Fix buggy tooltip for Equipped Items #9290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LocalIdentity merged 2 commits into from
Nov 22, 2025
Merged

Fix buggy tooltip for Equipped Items #9290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffa84e6
fix tooltip sometimes not showing in ItemsTab on dropdown items
Peechey Nov 18, 2025
e838816
comments, remove console logs
Peechey Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/Classes/ItemSlotControl.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,9 @@ local ItemSlotClass = newClass("ItemSlotControl", "DropDownControl", function(se
self.abyssalSocketList = { }
self.tooltipFunc = function(tooltip, mode, index, itemId)
local item = itemsTab.items[self.items[index]]
if main.popups[1] or mode == "OUT" or not item or (not self.dropped and itemsTab.selControl and itemsTab.selControl ~= self.controls.activate) then
tooltip:Clear()
-- not selControl.ListControl allows hover when All Items or Unique/Rare DB Sections are in focus
if main.popups[1] or mode == "OUT" or not item or (not self.dropped and itemsTab.selControl and itemsTab.selControl ~= self.controls.activate and not itemsTab.selControl.ListControl) then
tooltip:Clear(true)
elseif tooltip:CheckForUpdate(item, launch.devModeAlt, itemsTab.build.outputRevision) then
itemsTab:AddItemTooltip(tooltip, item, self)
end
Expand Down
5 changes: 4 additions & 1 deletion src/Classes/Tooltip.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,12 @@ local TooltipClass = newClass("Tooltip", function(self)
self:Clear()
end)

function TooltipClass:Clear()
function TooltipClass:Clear(clearUpdateParams)
wipeTable(self.lines)
wipeTable(self.blocks)
if self.updateParams and clearUpdateParams then
wipeTable(self.updateParams)
end
self.tooltipHeader = false
self.titleYOffset = 0
self.recipe = nil
Expand Down