Skip to content

Add support for Foulborn Ancestral Vision #9299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LocalIdentity merged 2 commits into from
Nov 21, 2025
Merged

Add support for Foulborn Ancestral Vision #9299

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2dfbfb8
add support for suppress applies to chance to defend with 200% armour…
Peechey Nov 20, 2025
dae3e7c
pr comments, use Max instead of Sum
Peechey Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/Modules/CalcDefence.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1500,6 +1500,17 @@ function calcs.defence(env, actor)
-- Ancestral Vision
modDB:NewMod("AvoidElementalAilments", "BASE", m_floor(spellSuppressionToAilmentPercent * spellSuppressionChance), "Ancestral Vision")
end
if modDB:Flag(nil, "SpellSuppressionAppliesToChanceToDefendWithArmour") then
local spellSuppressionAppliesToChanceToDefendWithArmourPercent = (modDB:Sum("BASE", nil, "SpellSuppressionAppliesToChanceToDefendWithArmourPercent") or 0) / 100
local spellSuppressionAppliesToChanceToDefendWithArmourPercentArmour = (modDB:Sum("BASE", nil, "SpellSuppressionAppliesToChanceToDefendWithArmourPercentArmour") or 0)
-- Foulborn Ancestral Vision
modDB:NewMod("ArmourDefense", "MAX", tonumber(spellSuppressionAppliesToChanceToDefendWithArmourPercentArmour) - 100, "Ancestral Vision: Max Calc", { type = "Condition", var = "ArmourMax" })
modDB:NewMod("ArmourDefense", "MAX", math.min((spellSuppressionAppliesToChanceToDefendWithArmourPercent * spellSuppressionChance) / 100, 1.0) * (tonumber(spellSuppressionAppliesToChanceToDefendWithArmourPercentArmour) - 100), "Ancestral Vision: Average Calc", { type = "Condition", var = "ArmourAvg" })
modDB:NewMod("ArmourDefense", "MAX", math.min(math.floor((spellSuppressionAppliesToChanceToDefendWithArmourPercent * spellSuppressionChance) / 100), 1.0) * (tonumber(spellSuppressionAppliesToChanceToDefendWithArmourPercentArmour) - 100), "Ancestral Vision: Min Calc", { type = "Condition", var = "ArmourMax", neg = true }, { type = "Condition", var = "ArmourAvg", neg = true })
-- already calc'ed above, need to run again
output.ArmourDefense = (modDB:Max(nil, "ArmourDefense") or 0) / 100
output.RawArmourDefense = output.ArmourDefense > 0 and ((1 + output.ArmourDefense) * 100) or nil
end

-- This is only used for breakdown purposes
if modDB:Flag(nil, "ShockAvoidAppliesToElementalAilments") then
Expand Down
5 changes: 5 additions & 0 deletions src/Modules/ModParser.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3538,6 +3538,11 @@ local specialModList = {
mod("SpellSuppressionAppliesToAilmentAvoidancePercent", "BASE", num),
flag("SpellSuppressionAppliesToAilmentAvoidance")
} end,
["modifiers to chance to suppress spell damage also apply to chance to defend with (%d+)%% of armour at (%d+)%% of their value"] = function (armourPercentage, _, effectiveness) return {
mod("SpellSuppressionAppliesToChanceToDefendWithArmourPercentArmour", "BASE", armourPercentage),
mod("SpellSuppressionAppliesToChanceToDefendWithArmourPercent", "BASE", effectiveness),
flag("SpellSuppressionAppliesToChanceToDefendWithArmour"),
} end,
["enemies chilled by your hits have damage taken increased by chill effect"] = { flag("ChillEffectIncDamageTaken") },
["left ring slot: your chilling skitterbot's aura applies socketed h?e?x? ?curse instead"] = { flag("SkitterbotsCannotChill", { type = "SlotNumber", num = 1 }) },
["right ring slot: your shocking skitterbot's aura applies socketed h?e?x? ?curse instead"] = { flag("SkitterbotsCannotShock", { type = "SlotNumber", num = 2 }) },
Expand Down