docs: add developer guides for SDK error handling#23
Merged
Patrick-Ehimen merged 1 commit intomainfrom Oct 15, 2025
Merged
Conversation
Reviewer's GuideIntroduces a new documentation structure under apps/docs, including a main index and two detailed guides for integrating and configuring the SDK's error handling system with code samples and best practices. Class diagram for SDK error handling configuration typesclassDiagram
class LighthouseConfig {
+string apiKey
+string baseUrl
+number timeout
+number maxRetries
+boolean debug
}
class ErrorHandler {
+number maxRetries
+number baseDelay
+number maxDelay
+number backoffMultiplier
+boolean jitter
+number timeout
}
class CircuitBreaker {
+number failureThreshold
+number successThreshold
+number timeout
+number monitoringWindow
}
LighthouseAISDK --> LighthouseConfig
LighthouseAISDK --> ErrorHandler
LighthouseAISDK --> CircuitBreaker
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- The README references troubleshooting/common-issues.md and troubleshooting/error-scenarios.md but those files aren’t included—please add them or update the links.
- There’s duplication of the basic configuration snippet in the integration guide and README; consider centralizing that example or linking directly to the configuration reference.
- The integration guide covers retries and metrics but doesn’t link to the circuit breaker section—adding a cross‐reference would help users find that configuration more easily.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The README references troubleshooting/common-issues.md and troubleshooting/error-scenarios.md but those files aren’t included—please add them or update the links.
- There’s duplication of the basic configuration snippet in the integration guide and README; consider centralizing that example or linking directly to the configuration reference.
- The integration guide covers retries and metrics but doesn’t link to the circuit breaker section—adding a cross‐reference would help users find that configuration more easily.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds comprehensive developer documentation for the SDK error handling system, including integration guides, andconfiguration references
Summary by Sourcery
Provide comprehensive developer documentation for the SDK error handling system, including a main README, an SDK Integration Guide, and a Configuration Reference.
Documentation: