Skip to content

Always allow links #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
thet wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Always allow links #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/tiptap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,12 @@ export default Base.extend({
(await import("@tiptap/extension-hard-break")).default.configure(),
// Gapcursor for images, tables etc to be able to add content below/above.
(await import("@tiptap/extension-gapcursor")).Gapcursor.configure(),
// Always include basic link extension.
(await import("./extensions/link")).factory().configure({
HTMLAttributes: { target: null, rel: null }, // don't set these attributes.
openOnClick: false, // don't open documents while editing.
linkOnPaste: true,
}),
];
const placeholder = this.el.getAttribute("placeholder");
if (placeholder) {
Expand Down
10 changes: 0 additions & 10 deletions src/toolbar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,16 +157,6 @@ export async function init_extensions({ app }) {
extensions.push((await import("@tiptap/extension-history")).History);
}

if (tb.link) {
extensions.push(
(await import("./extensions/link")).factory().configure({
HTMLAttributes: { target: null, rel: null }, // don't set these attributes.
openOnClick: false, // don't open documents while editing.
linkOnPaste: true,
})
);
}

if (tb.image) {
extensions.push((await import("./extensions/image-inline")).factory());
extensions.push((await import("./extensions/image-figure")).factory());
Expand Down