Added ability to change DMX start code and lengthened SPACE for BREAK #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was developing a DMX decoder on an FPGA, and was using DmxSimple to test it. I noticed that the reset pulse (SPACE for BREAK) was shorter than the minimum (92us) specified in the DMX512-A spec (ANSI E1.11-2008 (R2018)), so I lengthened it from 80us to 100us.
I also added an experimental feature to set the start code of the DMX frame. I say experimental because the features necessary to make this change useful outside of experimentation are lacking. Each start code should have its own buffer (which could be dynamically allocated) to prevent sending unintended data with any given start code, which would happen in the current implementation. I added this feature to test my decoder's rejection of frames with a non-zero start code.