Added compatbility for RedBearLab nRF51822 and BLENano #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an high level wrapper for DELAY_MICROSECONDS(us)
Compatibility by adding a new high level wrapper function for DELAY_MICROSECONDS(us)
Linked to wrong nRF51822_API.h header file
|
i opened an issue on https://github.com/RedBearLab/nRF51822-Arduino for this. the arduino primo uses a nrf52 and has its own board-library with a proper implementation of the delay()-family with use of nrf-functions. so i don't see why redBearLabs can't use these functions directly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As by "mrvanes" mentioned in this issue (#3) there were timing issues for using the OneWire library with RedBearLab's nRF51822 products. He mentioned a simple solution by adding another high level wrapper for DELAY_MICROSECONDS(...) in conclusion with including the <nRF51822_API.h> header for using all the necessary nRF specific functions. By including the nRF SDK to your compiler include paths the library was tested with my nRF51822 (v1.0/v1.5) and BLENano (v1.0/v1.5) by reading the sensor data from various DS18B20 sensors.