-
Notifications
You must be signed in to change notification settings - Fork 420
updating codebase of lib #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ibrary Registry manifest file Signed-off-by: Roman3349 <[email protected]>
Add information about library to @platformio Library Registry manifest file
from 5186 / 396 byte to 5160 / 395 byte on atmega with ds18x20 example
|
Hi Paul, it is hard to guess your thoughts when you say nothing at all.
|
| /// | ||
| /// \return true = a device responds with a presence pulse. | ||
| /// false = there is no device or the bus is shorted or otherwise held low for more than 250uS | ||
| bool reset(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has the same problem as the original version (#79). You can't tell the difference between no devices and a shorted bus.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, it could be changed easily but brings one more comparison. and it will break old code. most codebases will only test for non-zero. On the other hand - a major version change should be allowed to break code (with proper documentation).
the most elegant solution (so old code still works) would be to add a register for error-codes that could be checked.
hi paul, i know you only anticipate PR for new hardware support because you say the lib has "very mature code", but this statement is simply not true. over the years it became a big patchwork of ancient or even useless code. there were several bugs to find. the most obvious one is in the bus-power feature. the function write_bit() always powers the bus without permission. I modernized and extended the interface of the lib without breaking old code. i did tests on several platforms. see list of changes below.
where do you see problems in merging this PR?
I would like to co-maintain the onewire-lib with you. Currently I have rebuild and maintained the https://github.com/orgua/OneWireHub project for emulating slave-devices and i would like to apply my experiences to the onewire-master-lib.
changes i made so far: