[USB] Replace NUM_INTERFACE define with a NUM_INTERFACE() function#766
Open
forderud wants to merge 7 commits intoPaulStoffregen:masterfrom
Open
[USB] Replace NUM_INTERFACE define with a NUM_INTERFACE() function#766forderud wants to merge 7 commits intoPaulStoffregen:masterfrom
forderud wants to merge 7 commits intoPaulStoffregen:masterfrom
Conversation
Move the "core_pins.h" includes in usb.c and usb_seremu.c up to enable building the sources as C++ code. The "core_pins.h" include needs to be placed above the "usb_serial.h" and "usb_seremu.h" includes, since these headers contain C++ code that depends on functions in "core_pins.h".
Fixes the following compiler errors if renaming the sources in question from .c to .cpp:
In file included from teensy4\usb.cpp:5:
teensy4\usb_seremu.h: In member function 'void usb_seremu_class::begin(long int)':
teensy4\usb_seremu.h:68:41: error: 'systick_millis_count' was not declared in this scope
68 | uint32_t millis_begin = systick_millis_count;
| ^~~~~~~~~~~~~~~~~~~~
teensy4\usb_seremu.h:79:25: error: 'yield' was not declared in this scope
79 | yield();
| ^~~~~
teensy4\usb_seremu.h: In member function 'usb_seremu_class::operator bool()':
teensy4\usb_seremu.h:102:27: error: 'yield' was not declared in this scope
102 | operator bool() { yield(); return usb_configuration && usb_seremu_online; }
| ^~~~~
In file included from teensy4\usb_seremu.cpp:32:
teensy4\usb_seremu.h: In member function 'void usb_seremu_class::begin(long int)':
teensy4\usb_seremu.h:68:41: error: 'systick_millis_count' was not declared in this scope
68 | uint32_t millis_begin = systick_millis_count;
| ^~~~~~~~~~~~~~~~~~~~
teensy4\usb_seremu.h:79:25: error: 'yield' was not declared in this scope
79 | yield();
| ^~~~~
teensy4\usb_seremu.h: In member function 'usb_seremu_class::operator bool()':
teensy4\usb_seremu.h:102:27: error: 'yield' was not declared in this scope
102 | operator bool() { yield(); return usb_configuration && usb_seremu_online; }
| ^~~~~
Done to avoid the need for manually keeping NUM_INTERFACE in sync when experimenting with different USB device types with different number of interfaces. The function needs to be constexpr, since it's used to initialize USB configuration descriptors in PROGMEM.
forderud
force-pushed
the
NUM_INTERFACE-fn
branch
from
e227bdc to
1f0069a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on #767 and #763 to be merged first.
Done to avoid the need for manually keeping
NUM_INTERFACEin sync when experimenting with different USB device types with different number of interfaces. I can submit a PR that does the same also forNUM_ENDPOINTSif there's interest.The function needs to be
constexpr, since it's used to initialize USB configuration descriptors inPROGMEM.