Update File to mark overridden functions as 'override'#772
Update File to mark overridden functions as 'override'#772ssilverman wants to merge 1 commit intoPaulStoffregen:masterfrom
Conversation
a7bff4f to
801cec2
Compare
|
Note to reviewer: I can use 'virtual' instead, if you like, but the following PR will change all overridden methods to use 'override' instead of 'virtual': #771. |
This shouldn't be the case. If a derived class implements a virtual method from the base class it automatically replaces it without any extra notation required. Specifying "override" is just a precaution that will make the compiler throw an error if there isn't a matching virtual base method. |
Oops, you're right. I'll update the PR description and title. Overridden/virtual/etc functions should still be marked as such. It's good practice so that people reading the code don't have to guess or research every function. Relevant portions of the spec:
|
801cec2 to
53a7c6e
Compare
No description provided.