Skip to content

fix signature of _lseek() stub #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
A-Dunstan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix signature of _lseek() stub #775

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion teensy4/startup.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -758,7 +758,7 @@ int _isatty(int fd __attribute__((unused)))
}

__attribute__((weak))
int _lseek(int fd __attribute__((unused)), long long offset __attribute__((unused)), int whence __attribute__((unused)))
off_t _lseek(int fd __attribute__((unused)), off_t offset __attribute__((unused)), int whence __attribute__((unused)))
Copy link
Contributor

@ssilverman ssilverman Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the file should also include <sys/types.h>.
Ref: https://pubs.opengroup.org/onlinepubs/9799919799/basedefs/sys_types.h.html

Copy link
Contributor Author

@A-Dunstan A-Dunstan Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally all the weak functions should be in a separate file (syscalls.c?) since startup.c isn't really a suitable place for them, but I was going for brevity in the hopes of a quick merge...

Copy link
Contributor

@ssilverman ssilverman Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was referring to the definition of off_t.

{
return -1;
}
Expand Down