Fix alias definitions for FLEXIO_TIMCFG_DISABLE_* to match reference manual#778
Open
brandondahler wants to merge 1 commit intoPaulStoffregen:masterfrom
Open
Fix alias definitions for FLEXIO_TIMCFG_DISABLE_* to match reference manual#778brandondahler wants to merge 1 commit intoPaulStoffregen:masterfrom
brandondahler wants to merge 1 commit intoPaulStoffregen:masterfrom
Conversation
e58977b to
60aba58
Compare
Contributor
|
I don't see why DISABLE_ON_TRIGGER_CHANGE should be left (even deprecated) if the value is incorrect. |
Author
|
We'd want to leave it if we're concerned about code-level backwards compatibility. Removing it will break code which compiles successfully using the current library version (using the incorrectly named definition). |
Contributor
|
But even if that code compiled it would still be broken so I don't see the benefit. |
Author
|
Fair point, I was thinking about both deprecations, but for that specific one you're fully right -- it probably causes the timer to be broken if that value is actually used so a build failure is better than a silent deprecation. Will push an update later to remove it fully. |
60aba58 to
cc270cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Definitions for
FLEXIO_TIMCFG_DISABLE_ON_TRIGGER_RISINGandFLEXIO_TIMCFG_DISABLE_ON_TRIGGER_CHANGEare incorrectly named and invalid (respectively) per the IMXRT1060RM Rev 3 reference manual, section 50.6.1.21.4, page 3004.Details
Per the manual, TIMDIS has these values:
FLEXIO_TIMCFG_DISABLE_ON_TRIGGER***_RISING***is configured to representFLEXIO_TIMCFG_TIMDIS(6), which is110b - Timer disabled on Trigger ***falling*** edgeFLEXIO_TIMCFG_DISABLE_ON_TRIGGER_CHANGEis configured to representFLEXIO_TIMCFG_TIMDIS(7), which is111b - ReservedProposed Solution
#define FLEXIO_TIMCFG_DISABLE_ON_TRIGGER_FALLING FLEXIO_TIMCFG_TIMDIS(6)has been added to fix the namingFLEXIO_TIMCFG_DISABLE_ON_TRIGGER_RISINGandFLEXIO_TIMCFG_DISABLE_ON_TRIGGER_CHANGEdefinitions remain as-is, but a deprecation comment has been appended similar to__CM7_CMSIS_VERSION_MAIN's definition