Skip to content

Make IPAddress operators use size_t and always return references #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spnda wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make IPAddress operators use size_t and always return references #781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions teensy/IPAddress.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@ class IPAddress : public Printable {
bool operator==(const uint8_t* addr);

// Overloaded index operator to allow getting and setting individual octets of the address
uint8_t operator[](int index) const { return _address.bytes[index]; };
uint8_t& operator[](int index) { return _address.bytes[index]; };
uint8_t& operator[](const size_t index) { return _address.bytes[index]; }
const uint8_t& operator[](const size_t index) const { return _address.bytes[index]; }

// Overloaded copy operators to allow initialisation of IPAddress objects from other types
IPAddress& operator=(const uint8_t *address);
Expand Down
8 changes: 4 additions & 4 deletions teensy3/IPAddress.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,12 +94,12 @@ class IPAddress : public Printable {
}

// Overloaded index operator to allow getting and setting individual octets of the address
uint8_t operator[](int index) const {
uint8_t& operator[](const size_t index) {
return _address.bytes[index];
};
uint8_t& operator[](int index) {
}
const uint8_t& operator[](const size_t index) const {
return _address.bytes[index];
};
}

// Overloaded copy operators to allow initialisation of IPAddress objects from other types
IPAddress& operator=(const uint8_t *address) {
Expand Down
8 changes: 4 additions & 4 deletions teensy4/IPAddress.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,12 +94,12 @@ class IPAddress : public Printable {
}

// Overloaded index operator to allow getting and setting individual octets of the address
uint8_t operator[](int index) const {
uint8_t& operator[](const size_t index) {
return _address.bytes[index];
};
uint8_t& operator[](int index) {
}
const uint8_t& operator[](const size_t index) const {
return _address.bytes[index];
};
}

// Overloaded copy operators to allow initialisation of IPAddress objects from other types
IPAddress& operator=(const uint8_t *address) {
Expand Down