Made transitions between screens consistent#3287
Open
tashilapathum wants to merge 5 commits intoPaulWoitaschek:mainfrom
Open
Made transitions between screens consistent#3287tashilapathum wants to merge 5 commits intoPaulWoitaschek:mainfrom
tashilapathum wants to merge 5 commits intoPaulWoitaschek:mainfrom
Conversation
Author
|
This also fixes issue #3281 |
Author
|
Hi @PaulWoitaschek, any issue preventing this PR from being merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed when opening a book from the list, there's a fade in animation, when closing it, the animation is zoom out but sometimes it just fades out if done immediately.
screen-20260102-172108-1767354649191.mp4
Those are the default nav 3 animations and it looks janky. So I added
transitionSpecsto make them consistent across all screens. I experimented with different transitions but settled in on simply fade in and out. Now it's like this:screen-20260102-172146-1767354689030.mp4
PS: I've been using this app for years for my audiobooks and it's the absolute best. Thank you for the amazing work.