Closed
Conversation
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Prajwal-Microsoft <[email protected]> Co-authored-by: Roopan-Microsoft <[email protected]> Co-authored-by: Ajit Padhi <[email protected]> Co-authored-by: Roopan P M <[email protected]> Co-authored-by: Pavan-Microsoft <[email protected]> Co-authored-by: Ross Smith <[email protected]> Co-authored-by: gpickett <[email protected]> Co-authored-by: Francia Riesco <[email protected]> Co-authored-by: Francia Riesco <[email protected]> Co-authored-by: Harmanpreet-Microsoft <[email protected]> Co-authored-by: UtkarshMishra-Microsoft <[email protected]> Co-authored-by: Prasanjeet-Microsoft <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kiran-Siluveru-Microsoft <[email protected]> Co-authored-by: Prashant-Microsoft <[email protected]> Co-authored-by: Rohini-Microsoft <[email protected]> Co-authored-by: Avijit-Microsoft <[email protected]> Co-authored-by: RaviKiran-Microsoft <[email protected]> Co-authored-by: Somesh Joshi <[email protected]> Co-authored-by: Himanshi Agrawal <[email protected]> Co-authored-by: pradeepjha-microsoft <[email protected]> Co-authored-by: Harmanpreet Kaur <[email protected]> Co-authored-by: Bangarraju-Microsoft <[email protected]> Co-authored-by: Harsh-Microsoft <[email protected]> Co-authored-by: Kanchan-Microsoft <[email protected]> Co-authored-by: Cristopher Coronado <[email protected]> Co-authored-by: Cristopher Coronado Moreira <[email protected]> Co-authored-by: Vamshi-Microsoft <[email protected]> Co-authored-by: Thanusree-Microsoft <[email protected]> Co-authored-by: Niraj Chaudhari (Persistent Systems Inc) <[email protected]> Co-authored-by: Rohini-Microsoft <[email protected]> Co-authored-by: Kingshuk-Microsoft <[email protected]> Co-authored-by: Ayaz-Microsoft <[email protected]> Co-authored-by: Abdul-Microsoft <[email protected]> Co-authored-by: Prekshith-Microsoft <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: NirajC-Microsoft <[email protected]> Co-authored-by: Roopan-Microsoft <[email protected]> Co-authored-by: Ajit Padhi <[email protected]> Co-authored-by: Roopan P M <[email protected]> Co-authored-by: Pavan-Microsoft <[email protected]> Co-authored-by: Ross Smith <[email protected]> Co-authored-by: gpickett <[email protected]> Co-authored-by: Francia Riesco <[email protected]> Co-authored-by: Francia Riesco <[email protected]> Co-authored-by: Harmanpreet-Microsoft <[email protected]> Co-authored-by: UtkarshMishra-Microsoft <[email protected]> Co-authored-by: Priyanka-Microsoft <[email protected]> Co-authored-by: Prasanjeet-Microsoft <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kiran-Siluveru-Microsoft <[email protected]> Co-authored-by: Prashant-Microsoft <[email protected]> Co-authored-by: Rohini-Microsoft <[email protected]> Co-authored-by: Avijit-Microsoft <[email protected]> Co-authored-by: RaviKiran-Microsoft <[email protected]> Co-authored-by: Somesh Joshi <[email protected]> Co-authored-by: Himanshi Agrawal <[email protected]> Co-authored-by: pradeepjha-microsoft <[email protected]> Co-authored-by: Harmanpreet Kaur <[email protected]> Co-authored-by: Bangarraju-Microsoft <[email protected]> Co-authored-by: Harsh-Microsoft <[email protected]> Co-authored-by: Kanchan-Microsoft <[email protected]> Co-authored-by: Cristopher Coronado <[email protected]> Co-authored-by: Cristopher Coronado Moreira <[email protected]> Co-authored-by: Vamshi-Microsoft <[email protected]> Co-authored-by: Thanusree-Microsoft <[email protected]> Co-authored-by: Rohini-Microsoft <[email protected]> Co-authored-by: Kingshuk-Microsoft <[email protected]> Co-authored-by: Ayaz-Microsoft <[email protected]> Co-authored-by: Abdul-Microsoft <[email protected]> Co-authored-by: Prekshith-Microsoft <[email protected]> Co-authored-by: Rafi-Microsoft <[email protected]>
- Updated test cases in `test_env_helper.py` to set environment variables as strings for boolean values. - Added multiple test cases in `test_lang_chain_agent.py` to validate content safety input and output handling, including blocking harmful content and ensuring proper memory management with chat history. - Enhanced `test_open_ai_functions.py` with tests for function calls and content safety validation, ensuring robust handling of various scenarios including unknown function calls and null answers. - Removed obsolete test file `test_azure_blob_storage_client.py`. - Expanded `test_content_safety_checker.py` to cover various scenarios for content safety checks, including handling harmful content, safe text validation, and error handling for HTTP responses.
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Roopan P M <[email protected]> Co-authored-by: Roopan-Microsoft <[email protected]> Co-authored-by: Pavan-Microsoft <[email protected]> Co-authored-by: Prasanjeet-Microsoft <[email protected]> Co-authored-by: Harmanpreet Kaur <[email protected]> Co-authored-by: Harmanpreet-Microsoft <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR contains a mix of dependency updates, test improvements, documentation additions, and minor code fixes. The title "fix: test" is vague given the breadth of changes included.
Changes:
- Updated Cypress from 15.3.0 to 15.8.1 and various Python dependencies
- Added comprehensive test coverage for ContentSafetyChecker and Admin module
- Added documentation for Azure deployment, resource cleanup, and parameter customization
- Fixed test assertions and environment variable handling
Reviewed changes
Copilot reviewed 40 out of 48 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/integration/ui/package.json | Updated Cypress to version 15.8.1 |
| tests/integration/ui/package-lock.json | Lockfile updates for Cypress and dependencies |
| pyproject.toml | Updated multiple Python package versions |
| code/tests/utilities/tools/test_content_safety_checker.py | Added 11 new unit tests for ContentSafetyChecker |
| code/tests/utilities/helpers/test_env_helper.py | Fixed boolean environment variable handling |
| code/tests/test_admin.py | New test file for Admin.py module |
| code/frontend/src/components/ChatMessageContainer/ChatMessageContainer.test.tsx | Improved test assertions |
| code/tests/utilities/test_azure_blob_storage_client.py | Deleted entire test file |
| docs/delete_resource_group.md | New documentation for resource cleanup |
| docs/customizing_azd_parameters.md | New documentation for deployment parameters |
| docs/azure_openai_model_quota_settings.md | New documentation for quota management |
| docs/azure_account_setup.md | New documentation for account setup |
| docs/images/*.png | Added binary image files for documentation |
| .github/workflows/create-release.yml | Updated actions/checkout from v5 to v6 |
| code/tests/functional/tests/backend_api/postgres_orchestrator/init.py | Empty file addition |
Files not reviewed (2)
- code/frontend/package-lock.json: Language not supported
- tests/integration/ui/package-lock.json: Language not supported
Comments suppressed due to low confidence (1)
code/tests/utilities/test_azure_blob_storage_client.py:1
- The entire test file for AzureBlobStorageClient has been deleted, removing all test coverage for blob storage operations including file_exists, upload_file, delete_file, upsert_blob_metadata, get_blob_sas, and get_container_sas methods. These tests should be restored or replacement tests should be provided.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information