Fix incorrect panic messages in MulAssign and DivAssign#23
Open
cyrusagent-staging[bot] wants to merge 1 commit intomainfrom
Open
Fix incorrect panic messages in MulAssign and DivAssign#23cyrusagent-staging[bot] wants to merge 1 commit intomainfrom
cyrusagent-staging[bot] wants to merge 1 commit intomainfrom
Conversation
…ntations Fixed copy-paste errors in error messages: - MulAssign now correctly reports "inplace multiplication" instead of "inplace subtraction" - DivAssign now correctly reports "inplace division" instead of "inplace subtraction" Also includes automatic formatting fixes from cargo fmt (import ordering and whitespace). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed copy-paste errors in error messages for operator trait implementations in
tensor/src/core/traits.rs.Changes
MulAssign): Changed panic message from "inplace subtraction" → "inplace multiplication"DivAssign): Changed panic message from "inplace subtraction" → "inplace division"These were clear copy-paste errors that would confuse developers debugging shape mismatch errors during in-place tensor operations.
Additional Changes
cargo fmt(import ordering and whitespace cleanup)Test Plan
🤖 Generated with Claude Code