iterate over list instead of it's indexes #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Larocceau
force-pushed
the
avoid-iteration-over-index-instead-of-words
branch
from
5973398 to
fdc3fdd
Compare
Pazl27
approved these changes
Feb 26, 2025
Owner
|
Thank you for your contribution. I didnt really test the project on windows only on linux and wsl but i will look into. Thank you very much |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cool project! I've tried running it on windows; the replacement of characters as you type does not seem to work.
Anyway, very tiny refactor to avoid some unneeded indirection!