-
Notifications
You must be signed in to change notification settings - Fork 287
Fix input sampling validation and SIPNET IC handling #3498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix input sampling validation and SIPNET IC handling #3498
Conversation
|
@mdietze @infotroph |
infotroph
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Overall this is looking very good. I'll leave some notes inline, but the main change I see needed is to put the test file in modules/uncertainty/tests/testthat rather than base/all/[...]. I also see what looks to me like the same check in two places -- is that a true duplicate or am I not seeing the reason both are needed?
changed the file location
|
@blesson07asd Will you be able to return to this soon? Seems like it's in pretty good shape overall. The biggest issue I see remaining is that |
|
@infotroph Apologies for the delay, I was in the middle of my semester exams, which are now over. I’ll resume work on this and get the remaining changes pushed ASAP. Thanks for your patience and support! |
This comment was marked as resolved.
This comment was marked as resolved.
c06e151 to
1d5478a
Compare
… tabbed indentation in Makefile.
…wice, and added `pkgdocs`
…wn.yml, docker-compose.yml, docker/docs/Dockerfile, scripts/build_pkgdown.R
7f07635 to
e4d6adc
Compare
mdietze
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why you added rhdf5 to the libraries in data.remote as you don't seem to use it anywhere in your code
This reverts commit 7026682.
d43f6c7
Issue Title
Fix Input Sampling Validation and Deterministic IC Handling
Problem
PEcAn improperly passed multiple input paths (e.g., initial conditions) to model configuration functions without upstream sampling. Models like SIPNET handled this by randomly selecting a path, violating PEcAn’s design where sampling should occur at the ensemble level. This led to:
Non-reproducible workflows (random IC selection).
Lack of validation for unsampled multi-path inputs.
Solution
Upstream Validation:
write.ensemble.configs now errors if an input has multiple paths but no sampling method ( in XML).
Ensures only one path per input is passed to model configs.