Skip to content

made changes as mentioned to BADM_IC_process using PEcAn Settings#3770

Open
shreyannandanwar wants to merge 2 commits intoPecanProject:developfrom
shreyannandanwar:multi-setting
Open

made changes as mentioned to BADM_IC_process using PEcAn Settings#3770
shreyannandanwar wants to merge 2 commits intoPecanProject:developfrom
shreyannandanwar:multi-setting

Conversation

@shreyannandanwar
Copy link
Contributor

Description

fixes #3699
tested with test-IC_BADM_Utilities.R
implemented PEcAn Settings successfully

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I agree that PEcAn Project may distribute my contribution under any or all of
    • the same license as the existing code,
    • and/or the BSD 3-clause license.
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@shreyannandanwar
Copy link
Contributor Author

@divine7022 should I also write special unit tests because I don't really see specific test for the implemented changes.

@shreyannandanwar shreyannandanwar changed the title made BADM_IC_process using PEcAn Settings made changes as mentioned to BADM_IC_process using PEcAn Settings Jan 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make BADM_IC_process() use PEcAn Settings / MultiSettings consistently

1 participant