Rothc: Soil file support + read options from settings file#3788
Open
infotroph wants to merge 15 commits intoPecanProject:developfrom
Open
Rothc: Soil file support + read options from settings file#3788infotroph wants to merge 15 commits intoPecanProject:developfrom
infotroph wants to merge 15 commits intoPecanProject:developfrom
Conversation
Member
Author
|
|
This was referenced Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Both were using constants hardcoded in write.config.RothC until now.
New utils function
Also adds
PEcAn.utils::netcdf2df(), intended to be a general-purpose "please just dump this netcdf into a dataframe" function. So far I've tested it on files with only one dimension that varies (e.g. site-level files that might have a constant lat/lon alongside the depth or time); I'd love if it worked for higher dimensions too but did not tackle that today.I use it here to read soil files -- I know
PEcAn.data.land::pool_ic_netcdf2list()would work for this, but I'd rather not pull all the data.land dependencies into a model package if I don't have to.Opinions requested on whether this is an improvement and where else it might come in handy.
Motivation and Context
Review Time Estimate
Types of changes
Checklist: