Skip to content

pkgdown: report full error text (+fix url typo)#3796

Open
infotroph wants to merge 3 commits intoPecanProject:developfrom
infotroph:pkgdown-url-parse
Open

pkgdown: report full error text (+fix url typo)#3796
infotroph wants to merge 3 commits intoPecanProject:developfrom
infotroph:pkgdown-url-parse

Conversation

@infotroph
Copy link
Member

Description

Seems the pkgdown job has been reportng success while failing to build data.atmosphere for a while, with the error reported as a warning that (1) doesn't contain enough information to debug it, and (2) doesn't mark the build as failed, making the deployment job just quietly remove the data.atmosphere package docs.

Here I fixed the Rd parsing error in data.atm and also refactored the build script to complain more loudly and with more diagnostic information when a package fails to build.

Motivation and Context

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I agree that PEcAn Project may distribute my contribution under any or all of
    • the same license as the existing code,
    • and/or the BSD 3-clause license.
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@AritraDey-Dev AritraDey-Dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just few small typos.otherwise lgtm !

Co-authored-by: Aritra Dey <155592377+AritraDey-Dev@users.noreply.github.com>
@infotroph infotroph enabled auto-merge February 2, 2026 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants