fixes the conflation of soil and microbial maintenance respiration by splitting it #202
fixes the conflation of soil and microbial maintenance respiration by splitting it #202ayushman1210 wants to merge 28 commits intoPecanProject:masterfrom
Conversation
Co-authored-by: David LeBauer <dlebauer@gmail.com>
Co-authored-by: David LeBauer <dlebauer@gmail.com>
Co-authored-by: David LeBauer <dlebauer@gmail.com>
Co-authored-by: David LeBauer <dlebauer@gmail.com>
Co-authored-by: David LeBauer <dlebauer@gmail.com>
ayushman1210
requested review from
Alomir,
dlebauer,
infotroph,
mdietze and
mswilburn
as code owners
Alomir
left a comment
Alomir
left a comment
There was a problem hiding this comment.
Thanks for putting this together, @ayushman1210! It's almost there, I have a few additions that should be made.
|
hey @Alomir i have made as per your suggestion |
|
Hi maintainers, |
ayushman1210
force-pushed
the
fix/split
branch
from
ee7a821 to
2e00602
Compare
|
Sorry for the delay, @ayushman1210 - and again, thanks for your work here. However, I think #207 (which you are going to work on) is going to supersede this task, making it obsolete. |
|
I would like to leave this PR in its current state until we see how #207 works out, if you don't mind. |
|
Got it, thanks for the update! I’ll focus on #207 then. Let me know if there’s anything specific you’d like me to prioritize. |
2 participants
Summary
This update fixes the conflation of soil and microbial maintenance respiration by splitting
maintRespirationinto:soilMaintRespirationmicrobeMaintRespirationIt also corrects the respiration temperature formulation by separating the base rate from the Q10 temperature effect.
Key Changes
maintRespirationwith explicit soil and microbe maintenance fluxes.rSoilcalculation:rSoil = soilMaintRespirationrSoil = microbeMaintRespiration + (1 - microbeEff) * microbeIngestionstate.hto match new flux definitions.Testing
--microbes[success]sipnet.out) generated successfully [success]Fixes #144