Conversation
dlebauer
left a comment
There was a problem hiding this comment.
Hi @ayushman1210 thank you for reporting this bug and submitting these changes.
Unfortunately, it looks like these changes. Include your updates to documentation, maybe the same as are in #203.
Could you please either take those files out of this PR or submit a new one so that the PR is focused on the related issue? Either approach would be fine.
And as a minor request, for future reference - it is helpful if you can prepend the branch name and pr title with the feature number.
|
Thanks @ayushman1210 - I'll defer to @Alomir for approval. |
Alomir
left a comment
There was a problem hiding this comment.
Thanks for the work! One name change suggestion, but more importantly a possible way to work around the false clang error.
Co-authored-by: Mike Longfritz <[email protected]>
… one at a time until the hash is empty
|
hey @Alomir please review this PR when you have some free time I have made changes as you suggested |
|
Hey @Alomir please give your review on this PR |
|
Hey @Alomir Whenever you have some free time, could you please review this PR? |
Created destroyContextMetadata() that
Added call to destroyContextMetadata() at the end of cleanupModel() function
Implementation Details
The implementation uses the uthash library's HASH_ITER and HASH_DEL macros for safe iteration and deletion:
Fixes
#211