successfully implemented the column header requirements for SIPNET ou…#240
Open
ayushman1210 wants to merge 9 commits intoPecanProject:masterfrom
Open
successfully implemented the column header requirements for SIPNET ou…#240ayushman1210 wants to merge 9 commits intoPecanProject:masterfrom
ayushman1210 wants to merge 9 commits intoPecanProject:masterfrom
Conversation
Contributor
Author
|
hey @dlebauer please review this pr when you have free time |
Collaborator
|
@ayushman1210 I don't see the change to |
Contributor
Author
|
@Alomir I updated sipnet.c (sipnet.c:outputHeader()) to remove the "Notes" metadata and now print a single uncommented header line of variable names. I ran the test suite: unit tests passed, but the smoke tests showed some expected differences (permission errors on a few smoke runs and an output diff for russell_2) because of the header change |
Contributor
Author
|
Hey @Alomir, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored Main Output Header
Removed: Metadata line with units and notes (e.g., "Notes: (PlantWoodC, PlantLeafC... in g C/m^2...")
Headers now contain only variable names on a single uncommented line:
Added Header Support for Single Output Files ( OutputItems.c and OutputItems.h)
Integrated Headers into Model Output sipnet.c
Test Results
All 12 unit tests pass, including:
Event file handling tests
Event type tests (fertilization, harvest, irrigation, planting, tillage)
Nitrogen cycle modeling
Parameter and climate input validation
The implementation ensures that:
Headers are single-line, not commented
Headers contain only variable names (no metadata/units)
Headers are always written by default
The --print-header flag still allows users to disable headers if needed
FIXES : #168