Open
Conversation
07cb827 to
6b19abe
Compare
758f026 to
74ae9d4
Compare
Contributor
Author
Alomir
requested changes
Feb 2, 2026
Collaborator
Alomir
left a comment
There was a problem hiding this comment.
Looks good, just a small suggestion for change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Location:
src/sipnet/events.c, line 183Description:
When reading event lines, the buffer is fixed at 1024 bytes, but there's no check to ensure event parameter strings don't exceed this size.
Issue:
While
fgets()will prevent buffer overflow, extremely long event parameter lines will be silently truncated, potentially causing:Impact:
Changes
Add validation after reading