Refactored Soil Respiration Flux Calculations#251
Open
ayushman1210 wants to merge 5 commits intoPecanProject:masterfrom
Open
Refactored Soil Respiration Flux Calculations#251ayushman1210 wants to merge 5 commits intoPecanProject:masterfrom
ayushman1210 wants to merge 5 commits intoPecanProject:masterfrom
Conversation
ayushman1210
requested review from
Alomir,
dlebauer,
infotroph,
mdietze and
mswilburn
as code owners
Contributor
Author
|
Hi @dlebauer when you have some free time, I’d appreciate it if you could review this PR. |
- Initialize unknownParams buffer with {0} for full zero-initialization
- Move rSoil flux calculation to calcMicrobeFluxes for better separation of concerns
- Remove completed TODO comment
ayushman1210
force-pushed
the
code_quality
branch
from
bc938a9 to
8c0cf39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored Soil Respiration Flux Calculations
Location
src/sipnet/sipnet.cDescription
The updatePoolsForSoil() function was mixing flux calculations with pool updates, violating SIPNET's general pattern where calculateFluxes() handles all flux computations before pool updates occur
Changes
Moved the fluxes.rSoil calculation for the microbe model from updatePoolsForSoil() to calcMicrobeFluxes(), ensuring all flux calculations happen in the dedicated flux calculation phase
Improves code maintainability by clearly separating concerns between flux calculations and state updates, and removes the TODO comment indicating incomplete refactoring.