Open
Conversation
infotroph
reviewed
Feb 27, 2026
| fprintf(out, "%8.2f ", envi.soilC); | ||
| fprintf(out, "%11.2f %9.2f", envi.coarseRootC, envi.fineRootC); | ||
| fprintf(out, " %8.2f %10.2f %15.3f %8.2f ", envi.litterC, envi.soilWater, | ||
| fprintf(out, "%8.4f ", envi.soilC); |
Member
There was a problem hiding this comment.
Here's the one I'll nitpick: I doubt we need more decimal places for soil C. Given it's always greater than zero (usually thousands of g/m2, sometimes hundreds, hardly ever tens) and highly variable, differences smaller than a gram aren't usually meaningful.
Suggested change
| fprintf(out, "%8.4f ", envi.soilC); | |
| fprintf(out, "%8.2f ", envi.soilC); |
Member
There was a problem hiding this comment.
It's possible the same argument applies to other C pools, but I'm less sure which ones. Keeping higher precision for trackers/fluxes than for pools does make sense to me, to avoid truncation at short timesteps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
How was this change tested?
Smoke and unit tests; testOutputHeader updated.
Checklist
docs/CHANGELOG.mdupdated with noteworthy changesclang-format(rungit clang-formatif needed)