Skip to content

get certificate and CSR id from algorithm object #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MhmodTayel wants to merge 4 commits into
base: master
Choose a base branch
from
Open

get certificate and CSR id from algorithm object #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
560f20b
get certificate and CSR id from algorithm object
Nov 1, 2022
ef0f382
edit package.json to upload npm package
Nov 1, 2022
cfe5859
2.6.2
Nov 1, 2022
2696f1b
revert unnecessary changes in package.json and add id type in algorit…
Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/certs/csr.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export class X509CertificateRequest extends CryptoCertificate implements core.Cr
action: "import",
type: "request",
attributes: {
id: hashSPKI,
id: keyAlg.id || hashSPKI,
label: algorithm.label || "X509 Request",
token: !!(algorithm.token),
},
Expand Down
2 changes: 1 addition & 1 deletion src/certs/x509.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export class X509Certificate extends CryptoCertificate implements core.CryptoX50
action: "import",
type: "x509",
attributes: {
id: hashSPKI,
id: keyAlg.id || hashSPKI,
label: algorithm.label || certLabel,
token: !!(algorithm.token),
},
Expand Down
3 changes: 2 additions & 1 deletion src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import * as pvtsutils from "pvtsutils";
export type ITemplate = graphene.ITemplate;

export interface Pkcs11Attributes {
id?: pvtsutils.BufferSource;
id?: string | pvtsutils.BufferSource;
token?: boolean;
sensitive?: boolean;
label?: string;
Expand Down Expand Up @@ -98,6 +98,7 @@ export interface Pkcs11Params {
token?: boolean;
sensitive?: boolean;
label?: string;
id?: string;
}

export interface AlwaysAuthenticateParams {
Expand Down