Skip to content

RSET Maps#523

Open
chraibi wants to merge 20 commits intoPedestrianDynamics:mainfrom
chraibi:rset
Open

RSET Maps#523
chraibi wants to merge 20 commits intoPedestrianDynamics:mainfrom
chraibi:rset

Conversation

@chraibi
Copy link
Copy Markdown
Collaborator

@chraibi chraibi commented Mar 14, 2026

closes #508

@chraibi chraibi marked this pull request as draft March 14, 2026 13:25
@chraibi chraibi changed the title Rset RSET Mar 14, 2026
@chraibi chraibi changed the title RSET RSET Maps Mar 14, 2026
@chraibi chraibi marked this pull request as ready for review March 17, 2026 14:57
Copy link
Copy Markdown
Collaborator

@schroedtert schroedtert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some minor things, but overall it looks great!

Copilot AI review requested due to automatic review settings March 23, 2026 07:45
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for computing and visualizing RSET (Required Safe Egress Time) maps, aligning with the ASET–RSET map concept from Issue #508.

Changes:

  • Introduces compute_rset_map and RsetMethod for aggregating time-per-grid-cell from trajectory data.
  • Adds plot_rset_map and exposes the new API via pedpy.__init__.
  • Adds unit tests and user guide documentation for the new RSET map functionality.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
pedpy/methods/profile_calculator.py Adds RsetMethod and compute_rset_map implementation based on 2D binning.
pedpy/plotting/plotting.py Adds plot_rset_map helper to visualize computed RSET maps.
pedpy/__init__.py Re-exports RsetMethod, compute_rset_map, and plot_rset_map as public API.
tests/utils/utils.py Adds a small helper (make_traj) for constructing TrajectoryData in tests.
tests/unit_tests/methods/test_rset_map.py Adds comprehensive unit tests for RSET map computation and edge cases.
notebooks/user_guide.ipynb Documents RSET maps and provides an example workflow and plotting snippet.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

chraibi and others added 9 commits March 23, 2026 08:52
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@chraibi chraibi requested a review from schroedtert March 23, 2026 10:02
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 23, 2026

Codecov Report

❌ Patch coverage is 88.57143% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.25%. Comparing base (29f9126) to head (ff2bd0a).

Files with missing lines Patch % Lines
pedpy/methods/profile_calculator.py 88.57% 4 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RSET Maps

3 participants