Open
Conversation
chraibi
commented
Mar 14, 2026
Nan: not visited at all 0: visited at t=0
schroedtert
reviewed
Mar 20, 2026
Collaborator
schroedtert
left a comment
There was a problem hiding this comment.
Only some minor things, but overall it looks great!
There was a problem hiding this comment.
Pull request overview
Adds support for computing and visualizing RSET (Required Safe Egress Time) maps, aligning with the ASET–RSET map concept from Issue #508.
Changes:
- Introduces
compute_rset_mapandRsetMethodfor aggregating time-per-grid-cell from trajectory data. - Adds
plot_rset_mapand exposes the new API viapedpy.__init__. - Adds unit tests and user guide documentation for the new RSET map functionality.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
pedpy/methods/profile_calculator.py |
Adds RsetMethod and compute_rset_map implementation based on 2D binning. |
pedpy/plotting/plotting.py |
Adds plot_rset_map helper to visualize computed RSET maps. |
pedpy/__init__.py |
Re-exports RsetMethod, compute_rset_map, and plot_rset_map as public API. |
tests/utils/utils.py |
Adds a small helper (make_traj) for constructing TrajectoryData in tests. |
tests/unit_tests/methods/test_rset_map.py |
Adds comprehensive unit tests for RSET map computation and edge cases. |
notebooks/user_guide.ipynb |
Documents RSET maps and provides an example workflow and plotting snippet. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
schroedtert
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #508